Changeset 9241

Timestamp:

Oct 3, 2009, 2:10:52 PM (13 years ago)

Author:

livings124

Message:

random trivial adjustments

Location:

trunk/macosx

Files:

• BadgeView.m (modified) (1 diff)
• GroupsController.m (modified) (8 diffs)
• TorrentCell.m (modified) (1 diff)
• TorrentTableView.m (modified) (1 diff)
• TrackerTableView.m (modified) (1 diff)

trunk/macosx/BadgeView.m

@@ -117 +117 @@
     }
     
-    NSRect badgeRect = NSZeroRect;
+    NSRect badgeRect;
     badgeRect.size = [badge size];
+    badgeRect.origin.x = 0;
     badgeRect.origin.y = height;
     

trunk/macosx/GroupsController.m

@@ -67 +67 @@
                                             [NSColor redColor], @"Color",
                                             NSLocalizedString(@"Red", "Groups -> Name"), @"Name",
-                                            [NSNumber numberWithInt: 0], @"Index", nil];
+                                            [NSNumber numberWithInteger: 0], @"Index", nil];
             
             NSMutableDictionary * orange = [NSMutableDictionary dictionaryWithObjectsAndKeys:
                                             [NSColor orangeColor], @"Color",
                                             NSLocalizedString(@"Orange", "Groups -> Name"), @"Name",
-                                            [NSNumber numberWithInt: 1], @"Index", nil];
+                                            [NSNumber numberWithInteger: 1], @"Index", nil];
             
             NSMutableDictionary * yellow = [NSMutableDictionary dictionaryWithObjectsAndKeys:
                                             [NSColor yellowColor], @"Color",
                                             NSLocalizedString(@"Yellow", "Groups -> Name"), @"Name",
-                                            [NSNumber numberWithInt: 2], @"Index", nil];
+                                            [NSNumber numberWithInteger: 2], @"Index", nil];
             
             NSMutableDictionary * green = [NSMutableDictionary dictionaryWithObjectsAndKeys:
                                             [NSColor greenColor], @"Color",
                                             NSLocalizedString(@"Green", "Groups -> Name"), @"Name",
-                                            [NSNumber numberWithInt: 3], @"Index", nil];
+                                            [NSNumber numberWithInteger: 3], @"Index", nil];
             
             NSMutableDictionary * blue = [NSMutableDictionary dictionaryWithObjectsAndKeys:
                                             [NSColor blueColor], @"Color",
                                             NSLocalizedString(@"Blue", "Groups -> Name"), @"Name",
-                                            [NSNumber numberWithInt: 4], @"Index", nil];
+                                            [NSNumber numberWithInteger: 4], @"Index", nil];
             
             NSMutableDictionary * purple = [NSMutableDictionary dictionaryWithObjectsAndKeys:
                                             [NSColor purpleColor], @"Color",
                                             NSLocalizedString(@"Purple", "Groups -> Name"), @"Name",
-                                            [NSNumber numberWithInt: 5], @"Index", nil];
+                                            [NSNumber numberWithInteger: 5], @"Index", nil];
             
             NSMutableDictionary * gray = [NSMutableDictionary dictionaryWithObjectsAndKeys:
                                             [NSColor grayColor], @"Color",
                                             NSLocalizedString(@"Gray", "Groups -> Name"), @"Name",
-                                            [NSNumber numberWithInt: 6], @"Index", nil];
+                                            [NSNumber numberWithInteger: 6], @"Index", nil];
             
             fGroups = [[NSMutableArray alloc] initWithObjects: red, orange, yellow, green, blue, purple, gray, nil];
@@ -123 +123 @@
     {
         for (NSInteger i = 0; i < [fGroups count]; i++)
-            if (index == [[[fGroups objectAtIndex: i] objectForKey: @"Index"] intValue])
+            if (index == [[[fGroups objectAtIndex: i] objectForKey: @"Index"] integerValue])
                 return i;
     }
@@ -131 +131 @@
 - (NSInteger) indexForRow: (NSInteger) row
 {
-    return [[[fGroups objectAtIndex: row] objectForKey: @"Index"] intValue];
+    return [[[fGroups objectAtIndex: row] objectForKey: @"Index"] integerValue];
 }
 
@@ -257 +257 @@
         BOOL found = NO;
         for (NSDictionary * dict in fGroups)
-            if ([[dict objectForKey: @"Index"] intValue] == index)
+            if ([[dict objectForKey: @"Index"] integerValue] == index)
             {
                 found = YES;
@@ -267 +267 @@
     }
     
-    [fGroups addObject: [NSMutableDictionary dictionaryWithObjectsAndKeys: [NSNumber numberWithInt: index], @"Index",
+    [fGroups addObject: [NSMutableDictionary dictionaryWithObjectsAndKeys: [NSNumber numberWithInteger: index], @"Index",
                             [NSColor cyanColor], @"Color", @"", @"Name", nil]];
     
@@ -276 +276 @@
 - (void) removeGroupWithRowIndex: (NSInteger) row
 {
-    NSInteger index = [[[fGroups objectAtIndex: row] objectForKey: @"Index"] intValue];
+    NSInteger index = [[[fGroups objectAtIndex: row] objectForKey: @"Index"] integerValue];
     [fGroups removeObjectAtIndex: row];
     
     [[NSNotificationCenter defaultCenter] postNotificationName: @"GroupValueRemoved" object: self userInfo:
-        [NSDictionary dictionaryWithObject: [NSNumber numberWithInt: index] forKey: @"Index"]];
+        [NSDictionary dictionaryWithObject: [NSNumber numberWithInteger: index] forKey: @"Index"]];
     
     if (index == [[NSUserDefaults standardUserDefaults] integerForKey: @"FilterGroup"])
@@ -336 +336 @@
         [item setTarget: target];
         
-        [item setTag: [[dict objectForKey: @"Index"] intValue]];
+        [item setTag: [[dict objectForKey: @"Index"] integerValue]];
         
         NSImage * icon = [self imageForGroup: dict];
@@ -361 +361 @@
     for (NSDictionary * group in fGroups)
     {
-        NSInteger row = [[group objectForKey: @"Index"] intValue];
+        NSInteger row = [[group objectForKey: @"Index"] integerValue];
         if ([self torrent: torrent doesMatchRulesForGroupAtIndex: row])
             return row;

trunk/macosx/TorrentCell.m

@@ -429 +429 @@
     }
     
-    //error image
     const BOOL error = [torrent isErrorOrWarning];
-    NSImage * errorImage = error ? [NSImage imageNamed: [NSApp isOnSnowLeopardOrBetter] ? NSImageNameCaution : @"Error.png"] : nil;
     
     //icon
     if (!minimal || !(!fTracking && fHoverAction)) //don't show in minimal mode when hovered over
     {
-        NSImage * icon = (minimal && error) ? errorImage : [torrent icon];
+        NSImage * icon = (minimal && error) ? [NSImage imageNamed: [NSApp isOnSnowLeopardOrBetter] ? NSImageNameCaution : @"Error.png"]
+                                            : [torrent icon];
         [self drawImage: icon inRect: iconRect];
     }
     
+    //error badge
     if (error && !minimal)
     {
         NSRect errorRect = NSMakeRect(NSMaxX(iconRect) - ERROR_IMAGE_SIZE, NSMaxY(iconRect) - ERROR_IMAGE_SIZE,
                                         ERROR_IMAGE_SIZE, ERROR_IMAGE_SIZE);
-        [self drawImage: errorImage inRect: errorRect];
+        [self drawImage: [NSImage imageNamed: [NSApp isOnSnowLeopardOrBetter] ? NSImageNameCaution : @"Error.png"] inRect: errorRect];
     }
     

trunk/macosx/TorrentTableView.m

@@ -514 +514 @@
 }
 
+#warning catch string urls?
 - (void) paste: (id) sender
 {

trunk/macosx/TrackerTableView.m

@@ -120 +120 @@
     
     if (action == @selector(paste:))
-    {
         return fTorrent && ([NSApp isOnSnowLeopardOrBetter]
                 ? [[NSPasteboard generalPasteboard] canReadObjectForClasses: [NSArray arrayWithObject: [NSString class]] options: nil]
                 : [[NSPasteboard generalPasteboard] availableTypeFromArray: [NSArray arrayWithObject: NSStringPboardType]] != nil);
-    }
     
     return YES;