Changeset 9265

Timestamp:

Oct 10, 2009, 7:29:13 AM (13 years ago)

Author:

charles

Message:

(trunk gtk) #2485: Crash in preferences dialog when testing the open port

Location:

trunk/gtk

Files:

• my-valgrind.sh (modified) (1 diff)
• tr-prefs.c (modified) (1 diff)

trunk/gtk/my-valgrind.sh

@@ -3 +3 @@
 export G_DEBUG=gc-friendly
 export GLIBCXX_FORCE_NEW=1
-valgrind --tool=memcheck --leak-check=full --leak-resolution=high --num-callers=64 --log-file=x-valgrind --show-reachable=yes ./transmission -g /tmp/test
+valgrind --tool=memcheck --leak-check=full --leak-resolution=high --num-callers=64 --log-file=x-valgrind --show-reachable=yes ./transmission -g /tmp/crash

trunk/gtk/tr-prefs.c

@@ -1305 +1305 @@
     gtk_widget_set_sensitive( data->portSpin, FALSE );
     gtk_label_set_markup( GTK_LABEL( data->portLabel ), _( "<i>Testing...</i>" ) );
-    data->portTag = g_signal_connect( data->core, "port-tested", G_CALLBACK(onPortTested), data );
+    if( !data->portTag )
+        data->portTag = g_signal_connect( data->core, "port-tested", G_CALLBACK(onPortTested), data );
     tr_core_port_test( data->core );
 }