Changeset 9495

Timestamp:

Nov 8, 2009, 11:43:38 PM (11 years ago)

Author:

charles

Message:

(trunk libT) #2551 "better buffer cache management": apply jch's prefetch-base.patch

Location:

trunk/libtransmission

Files:

• fdlimit.c (modified) (1 diff)
• fdlimit.h (modified) (1 diff)
• inout.c (modified) (5 diffs)
• inout.h (modified) (1 diff)

trunk/libtransmission/fdlimit.c

@@ -209 +209 @@
 }
 
+/* Like pread and pwrite, except that the position is undefined afterwards.
+   And of course they are not thread-safe. */
+
+#ifdef SYS_DARWIN
+ #define HAVE_PREAD
+ #define HAVE_PWRITE
+#endif
+
+ssize_t
+tr_pread( int fd, void *buf, size_t count, off_t offset )
+{
+#ifdef HAVE_PREAD
+    return pread( fd, buf, count, offset );
+#else
+    const off_t lrc = lseek( fd, offset, SEEK_SET );
+    if( lrc < 0 )
+        return -1;
+    return read( fd, buf, count );
+#endif
+}
+
+ssize_t
+tr_pwrite( int fd, void *buf, size_t count, off_t offset )
+{
+#ifdef HAVE_PWRITE
+    return pwrite( fd, buf, count, offset );
+#else
+    const off_t lrc = lseek( fd, offset, SEEK_SET );
+    if( lrc < 0 )
+        return -1;
+    return write( fd, buf, count );
+#endif
+}
+
+int
+tr_prefetch( int fd, off_t offset, size_t count )
+{
+#ifdef HAVE_POSIX_FADVISE
+    return posix_fadvise( fd, offset, count, POSIX_FADV_WILLNEED );
+#elif defined(SYS_DARWIN)
+    int val;
+    struct radvisory radv;
+    radv.ra_offset = offset;
+    radv.ra_count = count;
+    return fcntl( fd, F_RDADVISE, &radv );
+#else
+    return 0;
+#endif
+}
+
 int
 tr_open_file_for_writing( const char * filename )

trunk/libtransmission/fdlimit.h

@@ -54 +54 @@
 
 int64_t tr_lseek( int fd, int64_t offset, int whence );
+ssize_t tr_pread(int fd, void *buf, size_t count, off_t offset);
+ssize_t tr_pwrite(int fd, void *buf, size_t count, off_t offset);
+int tr_prefetch(int fd, off_t offset, size_t count);
 
 

trunk/libtransmission/inout.c

@@ -51 +51 @@
 #endif
 
-enum { TR_IO_READ, TR_IO_WRITE };
+enum { TR_IO_READ, TR_IO_PREFETCH,
+       /* Any operations that require write access must follow TR_IO_WRITE. */
+       TR_IO_WRITE
+};
 
 int64_t
@@ -78 +81 @@
     const tr_file * file = &info->files[fileIndex];
 
-    typedef size_t ( *iofunc )( int, void *, size_t );
-    iofunc          func = ioMode == TR_IO_READ ? (iofunc)read : (iofunc)write;
     int             fd = -1;
     int             err = 0;
-    const tr_bool doWrite = ioMode == TR_IO_WRITE;
+    const tr_bool doWrite = ioMode >= TR_IO_WRITE;
 
     assert( fileIndex < info->fileCount );
@@ -114 +115 @@
         }
 
-        if( ( file->dnd ) || ( ioMode != TR_IO_WRITE ) )
+        if( ( file->dnd ) || ( ioMode < TR_IO_WRITE ) )
             preallocationMode = TR_PREALLOCATE_NONE;
         else
             preallocationMode = tor->session->preallocationMode;
 
-        if( ( ioMode == TR_IO_READ ) && !fileExists ) /* does file exist? */
+        if( ( ioMode < TR_IO_WRITE ) && !fileExists ) /* does file exist? */
         {
             err = ENOENT;
@@ -145 +146 @@
     if( !err )
     {
-        if( tr_lseek( fd, (int64_t)fileOffset, SEEK_SET ) == -1 )
-        {
-            err = errno;
-            tr_torerr( tor, "tr_lseek failed for \"%s\": %s", file->name, tr_strerror( err ) );
-        }
-        else if( func( fd, buf, buflen ) != buflen )
-        {
-            err = errno;
-            tr_torerr( tor, "read/write failed for \"%s\": %s", file->name, tr_strerror( err ) );
-        }
+        if( ioMode == TR_IO_READ ) {
+            int rc = tr_pread(fd, buf, buflen, fileOffset);
+            if(rc < 0) {
+                err = errno;
+                tr_torerr( tor, "read failed for \"%s\": %s",
+                           file->name, tr_strerror( err ) );
+            }
+        } else if( ioMode == TR_IO_PREFETCH ) {
+            int rc = tr_prefetch(fd, fileOffset, buflen);
+            if(rc < 0) {
+                err = errno;
+                tr_torerr( tor, "prefetch failed for \"%s\": %s",
+                           file->name, tr_strerror( err ) );
+            }
+        } else if( ioMode == TR_IO_WRITE ) {
+            int rc = tr_pwrite(fd, buf, buflen, fileOffset);
+            if(rc < 0) {
+                err = errno;
+                tr_torerr( tor, "write failed for \"%s\": %s",
+                           file->name, tr_strerror( err ) );
+            }
+        } else
+            abort();
     }
 
@@ -248 +262 @@
 
 int
+tr_ioPrefetch( tr_torrent       * tor,
+               tr_piece_index_t   pieceIndex,
+               uint32_t           begin,
+               uint32_t           len)
+{
+    return readOrWritePiece( tor, TR_IO_PREFETCH, pieceIndex, begin,
+                             NULL, len );
+}
+
+int
 tr_ioWrite( tr_torrent       * tor,
             tr_piece_index_t   pieceIndex,

trunk/libtransmission/inout.h

@@ -35 +35 @@
                uint8_t             * setme );
 
+int
+tr_ioPrefetch( tr_torrent       * tor,
+               tr_piece_index_t   pieceIndex,
+               uint32_t           begin,
+               uint32_t           len );
+
 /**
  * Writes the block specified by the piece index, offset, and length.