Changeset 9699 for trunk/macosx/MessageWindowController.m

Timestamp:

Dec 10, 2009, 4:49:57 AM (13 years ago)

Author:

livings124

Message:

on second thought, there's no need to store the index at all - it's just the number of messages we have

File:

• trunk/macosx/MessageWindowController.m (modified) (4 diffs)

trunk/macosx/MessageWindowController.m

@@ -156 +156 @@
     [fLock lock];
     
+    NSUInteger currentCount = [fMessages count];
+    
     NSScroller * scroller = [[fMessageTable enclosingScrollView] verticalScroller];
-    const BOOL shouldScroll = fCurrentIndex == 0 || [scroller floatValue] == 1.0 || [scroller isHidden]
+    const BOOL shouldScroll = currentCount == 0 || [scroller floatValue] == 1.0 || [scroller isHidden]
                                 || [scroller knobProportion] == 1.0;
     
@@ -174 +176 @@
                                     [NSString stringWithUTF8String: currentMessage->message], @"Message",
                                     [NSDate dateWithTimeIntervalSince1970: currentMessage->when], @"Date",
-                                    [NSNumber numberWithUnsignedInteger: fCurrentIndex++], @"Index", //more accurate when sorting by date
+                                    [NSNumber numberWithUnsignedInteger: currentCount++], @"Index", //more accurate when sorting by date
                                     [NSNumber numberWithInteger: currentMessage->level], @"Level",
                                     name, @"Name",
@@ -188 +190 @@
     }
     
-    if ([fMessages count] > TR_MAX_MSG_LOG)
-    {
-        NSIndexSet * removeIndexes = [NSIndexSet indexSetWithIndexesInRange: NSMakeRange(0, [fMessages count]-TR_MAX_MSG_LOG)];
+    if (currentCount > TR_MAX_MSG_LOG)
+    {
+        NSIndexSet * removeIndexes = [NSIndexSet indexSetWithIndexesInRange: NSMakeRange(0, currentCount-TR_MAX_MSG_LOG)];
         NSArray * itemsToRemove = [fMessages objectsAtIndexes: removeIndexes];
         
@@ -360 +362 @@
     [fDisplayedMessages removeAllObjects];
     [fMessageTable reloadData];
-    fCurrentIndex = 0;
     
     [fLock unlock];