Changeset 9762

Timestamp:

Dec 14, 2009, 7:24:05 PM (12 years ago)

Author:

charles

Message:

(trunk gtk) #2668 "minor memory leaks in gtk client" -- fix two GtkImages? that were being leaked in the main window

File:

• trunk/gtk/tr-window.c (modified) (5 diffs)

trunk/gtk/tr-window.c

@@ -96 +96 @@
     GtkWidget *           stats_lb;
     GtkWidget *           gutter_lb;
-    GtkWidget *           alt_speed_image[2]; /* 0==off, 1==on */
+    GtkWidget *           alt_speed_image;
     GtkWidget *           alt_speed_button;
     GtkWidget *           options_menu;
@@ -285 +285 @@
 {
     PrivateData * p = vprivate;
-
     g_signal_handler_disconnect( p->core, p->pref_handler_id );
-    g_object_unref( G_OBJECT( p->alt_speed_image[1] ) );
-    g_object_unref( G_OBJECT( p->alt_speed_image[0] ) );
     g_free( p->filter_text );
     g_free( p );
@@ -336 +333 @@
     const char * fmt;
     const gboolean b = pref_flag_get( TR_PREFS_KEY_ALT_SPEED_ENABLED );
+    const char * stock = b ? "alt-speed-on" : "alt-speed-off";
     GtkWidget * w = p->alt_speed_button;
 
@@ -345 +343 @@
 
     gtk_toggle_button_set_active( GTK_TOGGLE_BUTTON( w ), b );
-    gtk_button_set_image( GTK_BUTTON( w ), p->alt_speed_image[b?1:0] );
+    gtk_image_set_from_stock( GTK_IMAGE( p->alt_speed_image ), stock, -1 );
     gtk_button_set_alignment( GTK_BUTTON( w ), 0.5, 0.5 );
     gtr_widget_set_tooltip_text( w, str );
@@ -960 +958 @@
         g_signal_connect( w, "clicked", G_CALLBACK(onOptionsClicked), p );
 
-        p->alt_speed_image[0] = gtk_image_new_from_stock( "alt-speed-off", -1 );
-        p->alt_speed_image[1] = gtk_image_new_from_stock( "alt-speed-on", -1 );
+        p->alt_speed_image = gtk_image_new( );
         w = p->alt_speed_button = gtk_toggle_button_new( );
+        gtk_button_set_image( GTK_BUTTON( w ), p->alt_speed_image );
         gtk_button_set_relief( GTK_BUTTON( w ), GTK_RELIEF_NONE );
-        g_object_ref( G_OBJECT( p->alt_speed_image[0] ) );
-        g_object_ref( G_OBJECT( p->alt_speed_image[1] ) );
-        gtk_container_add( GTK_CONTAINER( w ), p->alt_speed_image[0] );
         g_signal_connect( w, "toggled", G_CALLBACK(alt_speed_toggled_cb ), p );
         gtk_box_pack_start( GTK_BOX( h ), w, 0, 0, 0 );