Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1064 closed Bug (fixed)

sexy-icon-entry.c uses deprecated gtk+ 2.13.x api

Reported by: ed@… Owned by: charles
Priority: Normal Milestone: 1.40
Component: GTK+ Client Version: 1.22
Severity: Minor Keywords:
Cc:

Description

i686-pc-linux-gnu-gcc -DPACKAGE_NAME=\"transmission\" -DPACKAGE_TARNAME=\"transmission\" -DPACKAGE_VERSION=\"1.20\" -DPACKAGE_STRING=\"transmission\ 1.20\" -DPACKAGE_BUGREPORT=\"http://trac.transmissionbt.com/newticket\" -DPACKAGE=\"transmission\" -DVERSION=\"1.20\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DSTDC_HEADERS=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_DAEMON=1 -DHAVE_DIRNAME=1 -DHAVE_BASENAME=1 -DSIZEOF_VOIDP=4 -DHAVE_PTHREAD=1 -D_FILE_OFFSET_BITS=64 -DHAVE_GIO=1 -DHAVE_LIBNOTIFY=1 -DHAVE_DBUS_GLIB=1 -DHAVE_LIBINTL_H=1 -DGETTEXT_PACKAGE=\"transmission\" -DHAVE_LOCALE_H=1 -DHAVE_LC_MESSAGES=1 -DHAVE_BIND_TEXTDOMAIN_CODESET=1 -DHAVE_GETTEXT=1 -DHAVE_DCGETTEXT=1 -DENABLE_NLS=1 -I.  -I.. -I../third-party/ -I../third-party/libevent -DTRANSMISSIONLOCALEDIR=\""/usr/share/locale"\"  -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/pixman-1   -I/usr/kerberos/include    -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/pixman-1   -g -Wall -W -O3 -funroll-loops -MT sexy-icon-entry.o -MD -MP -MF .deps/sexy-icon-entry.Tpo -c -o sexy-icon-entry.o sexy-icon-entry.c
sexy-icon-entry.c: In function ‘sexy_icon_entry_class_init’:
sexy-icon-entry.c:131: error: ‘gtk_marshal_VOID__INT_INT’ undeclared (first use in this function)
sexy-icon-entry.c:131: error: (Each undeclared identifier is reported only once
sexy-icon-entry.c:131: error: for each function it appears in.)
make[2]: *** [sexy-icon-entry.o] Error 1
make[2]: Leaving directory `/var/tmp/portage/net-p2p/transmission-1.20/work/transmission-1.20/gtk'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/net-p2p/transmission-1.20/work/transmission-1.20/gtk'
make: *** [all-recursive] Error 1

The gtk_* marshallers have been deprecated and removed in gtk+-2.13.

Some have been replaced by g_cclosure_* marshallers in gobject, but in this case you'll need to run glib-genmarshal.

Patch to follow.

Attachments (1)

gtk-marshal.patch (2.2 KB) - added by ed@… 13 years ago.

Download all attachments as: .zip

Change History (14)

Changed 13 years ago by ed@…

comment:1 Changed 13 years ago by charles

Thank you for the patch! The only downside that I see to this is that it breaks the build if the user has chosen to build without dbus. Can you modify this patch to conditionally do this based on the HAVE_DBUS_GLIB setting in configure.ac?

comment:2 Changed 13 years ago by charles

Sorry, for some reason I was confusing this with the dbus marshalling code that the gtk+ client is using.

Looks like you've already reported this bug upstream; thanks. :)

comment:3 follow-up: Changed 13 years ago by charles

looks like the gmarshal stuff has been made public again to unbreak this?

comment:4 Changed 13 years ago by charles

  • Summary changed from Build failure with gtk+-2.13: sexy-icon-entry.c:131: error: ‘gtk_marshal_VOID__INT_INT’ undeclared (first use in this function) to sexy-icon-entry.c doesn't compile with gtk+-2.13

comment:5 in reply to: ↑ 3 Changed 13 years ago by ed@…

Replying to charles:

looks like the gmarshal stuff has been made public again to unbreak this?

Hm, yes - still, the marshallers are deprecated (won't compile with -DGTK_DISABLE_DEPRECATED) and will be removed at some point in the future.

comment:6 Changed 13 years ago by charles

ISTR there used to be a libsexy website with periodic releases, but can't find that now. I wonder, is libsexy still maintained?

comment:7 Changed 13 years ago by charles

comment:8 Changed 13 years ago by charles

  • Milestone changed from None Set to Sometime

comment:9 Changed 13 years ago by charles

  • Summary changed from sexy-icon-entry.c doesn't compile with gtk+-2.13 to sexy-icon-entry.c uses deprecated gtk+ api

comment:10 Changed 13 years ago by muks

  • Summary changed from sexy-icon-entry.c uses deprecated gtk+ api to sexy-icon-entry.c uses deprecated gtk+ 2.13.x api

comment:11 Changed 13 years ago by charles

  • Milestone changed from Sometime to 1.40
  • Severity changed from Normal to Minor
  • Status changed from new to assigned

comment:12 Changed 13 years ago by charles

  • Keywords backport-candidate added
  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in r6872

comment:13 Changed 12 years ago by charles

  • Keywords backport-candidate removed
Note: See TracTickets for help on using tickets.