Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1069 closed Enhancement (invalid)

Unknown seeder & leecher count in `peers' tab

Reported by: nu11 Owned by: charles
Priority: Normal Milestone: None Set
Component: GTK+ Client Version: 1.22
Severity: Normal Keywords:
Cc:

Description

see screenshot: http://img76.imageshack.us/img76/6212/bugoq7.png

what information I should give you to fix that bug?

Change History (9)

comment:1 Changed 13 years ago by livings124

  • Resolution set to invalid
  • Status changed from new to closed

Some trackers don't supply this information, so it displays "?". This is intentional.

comment:2 Changed 13 years ago by nu11

but why do not check count of list elements and use it?

comment:3 Changed 13 years ago by livings124

Because those numbers are for the whole swarm, not who you happen to connect to.

comment:4 Changed 13 years ago by charles

  • Resolution invalid deleted
  • Status changed from closed to reopened

livings124 is correct, but now that you mention it, maybe it /would/ be good to use our local counts as a fallback if there's no information from the tracker.

comment:5 Changed 13 years ago by charles

  • Summary changed from unknown «Seeders», «Leechers» and «Completed» count in «Details» -> «Peers» dialog to Unknown seeder & leecher count in `peers' tab
  • Type changed from Bug to Enhancement

Added in gtk+ client in r6280.

livings124: I'm leaving this ticket open in case you want to use the numbers as a fallback in the mac client. either way is fine with me. feel free to close this ticket when you're done with it.

comment:6 Changed 13 years ago by livings124

  • Resolution set to fixed
  • Status changed from reopened to closed

I will not be changing this in the mac client, as those fields are explicitly "total" values. Changing the behavior to show one or the other would be inconsistent.

comment:7 Changed 13 years ago by charles

  • Resolution fixed deleted
  • Status changed from closed to reopened

livings124 is correct that the change makes these fields inconsistent. It probably is better to keep the behavior the way it was in 1.22.

comment:8 Changed 13 years ago by charles

  • Resolution set to invalid
  • Status changed from reopened to closed

reverted in r6283.

comment:9 Changed 13 years ago by nu11

maybe hide that labels as a fallback...

Note: See TracTickets for help on using tickets.