Opened 13 years ago

Closed 13 years ago

#1109 closed Bug (fixed)

“UL To” and “DL From” are switched in torrent inspector and peer details

Reported by: Murmex Owned by: charles
Priority: Normal Milestone: 1.30
Component: Web Client Version: 1.22+
Severity: Normal Keywords:
Cc:

Description

In the web client torrent inspector, the “UL To” and “DL From” are switched, so that “UL To” refers to the peers we are downloading from and “DL From” to the ones we are sending data.

This was probably caused by a confusion in the naming scheme between the json data sent by the server and the id of the fields in the html code, as we are switching from a “peers uploading“ naming scheme to “download from peers“.

This problems also occurs in the torrent list where “Dowloading from” and “Seeding to” use the wrong data.

I've joined a patch with the corrections at places where the naming scheme is the most logical.

Attachments (1)

js_patch_r6400 (1.4 KB) - added by Murmex 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by Murmex

comment:1 Changed 13 years ago by charles

  • Milestone changed from None Set to 1.30
  • Owner changed from Gimp to charles
  • Status changed from new to assigned

Heh. I've seen this bug before in the gtk+ client too. The ambiguity in upload/download is why libtransmission was changed to use peersGettingFromUs and peersSendingToUs. :)

comment:2 Changed 13 years ago by Murmex

Yup, using “downloading” and “uploading” can be too ambiguous depending on the situation. peersGettingFromUs and peersSendingToUs are much core clear and helped me a lot when looking for the problem.

comment:3 Changed 13 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in r6401

Note: See TracTickets for help on using tickets.