Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1116 closed Bug (fixed)

clean the remainings of php

Reported by: Murmex Owned by: Gimp
Priority: Normal Milestone: 1.33
Component: Web Client Version: 1.30
Severity: Normal Keywords:


Firstly, there are some <?php ?> tags in index.html that are completely useless as the daemon serves the files without processing them in a php engine. Worse, they clutter the html code. Their only use in that file is for iPhone detection. Directly using javascript for the browser sniffing would be better.

Secondly, there is a reference to “remote/index.php?action=savePrefs” in the preferences form. I don't really know what to do with this one. probably just replace it with “index.html”.

Lastly, we should do something about the addTorrentByURL() function at the end of transmission.remote.js which is commented and referred to another php file. Without server-side scripting, we probably need to add the functionality directly in the daemon code.

Change History (6)

comment:1 Changed 13 years ago by Gimp

  • Status changed from new to assigned

I've dealt with the first part, put in conditional css sheets to handle iphone, and removed the php from the index page. I'll get to the other parts in a bit.

comment:2 Changed 13 years ago by charles

  • Milestone changed from None Set to 1.30

comment:3 Changed 13 years ago by charles

  • Milestone changed from 1.30 to None Set
  • Version changed from 1.22+ to 1.30

comment:4 Changed 13 years ago by charles

Regarding the second point, I don't think the form needs an action at all, since the javascript takes care of saving the preferences in cookies.

AddTorrentByURL is gone and is probably not going to come back in the forseeable future unless someone provides a patch. Xref: #1147

comment:5 Changed 13 years ago by charles

  • Milestone changed from None Set to 1.40
  • Resolution set to fixed
  • Status changed from assigned to closed

trunk: r6494.

comment:6 Changed 13 years ago by livings124

  • Milestone changed from 1.40 to 1.33
Note: See TracTickets for help on using tickets.