Opened 15 years ago

Closed 11 years ago

#1131 closed Enhancement (fixed)

Allow preference changes on iPhone version

Reported by: rdougan Owned by: charles
Priority: Normal Milestone: 2.40
Component: Web Client Version: 1.22
Severity: Normal Keywords: feature-disparity
Cc: hadess@…, btaroli@…, adam.sindelar@…, bulljit@…

Description

You currently can only allow preference changes on the normal version of the web interface. It would be nice to allow support to change preferences from the iPhone too.

Change History (19)

comment:1 Changed 14 years ago by hadess

  • Cc hadess@… added

comment:2 Changed 14 years ago by taroliw

  • Cc btaroli@… added

comment:3 Changed 14 years ago by charles

  • Keywords patch-needed added

comment:4 Changed 14 years ago by adam

Hi, I'd like to have a go at this - can I just accept the ticket to make it clear I'm working on this?

comment:5 Changed 14 years ago by adam

  • Cc adam.sindelar@… added

comment:6 Changed 14 years ago by kjg

Sure, feel free to give it a go.

comment:7 Changed 14 years ago by adam

  • Owner changed from Gimp to adam
  • Status changed from new to assigned

comment:8 follow-up: Changed 13 years ago by matti

Is this still being worked on? I'm looking for new areas in the web client to contribute to.

comment:9 in reply to: ↑ 8 Changed 13 years ago by adam

Replying to matti:

Is this still being worked on? I'm looking for new areas in the web client to contribute to.

I've already implemented a lot of the functionality - I refactored some the js code responsible for showing and hiding of the preference pane, some of the HTML to allow for iPhone effects, and I implemented a 3D flip effect using CSS transitions. However, then a new version of Transmission came out with changes to the web client and I didn't have the time to merge the changes. I kept meaning to get back to this eventually, but work and school kept piling up, sorry.

At this moment, if I'm allowed to take my time implementing this, I won't be able to get back to it until about late November. So if you want to work on this, I can give you a ZIP archive with my changes, in case some of them are useful for you.

comment:10 Changed 13 years ago by KyleK

Maybe you can attach your changed files to this ticket, than anyone with the proper knowledge can try to work the HEAD changes into it.

comment:11 Changed 13 years ago by charles

  • Keywords feature-disparity added; patch-needed removed
  • Milestone changed from None Set to 2.10
  • Owner changed from adam to charles
  • Severity changed from Trivial to Normal
  • Status changed from assigned to new

comment:12 Changed 13 years ago by charles

  • Status changed from new to assigned

fixed in r11157, r11158.

I don't have access to an iPhone to test, so feedback is encouraged...

comment:13 Changed 13 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:14 Changed 13 years ago by livings124

  • Resolution fixed deleted
  • Status changed from closed to reopened

Unless I'm missing something, I cannot see how I can get to the preference dialog. Additionally, the turtle button seems to have disappeared from the bottom bar.

comment:15 Changed 12 years ago by livings124

  • Milestone changed from 2.10 to None Set

comment:16 Changed 12 years ago by charles

  • Milestone changed from None Set to Sometime

gearbox allows this

comment:17 Changed 12 years ago by bulljit

  • Cc bulljit@… added

comment:18 Changed 11 years ago by jordan

  • Milestone changed from Sometime to 2.40

comment:19 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in r12865.

Note: See TracTickets for help on using tickets.