Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1147 closed Enhancement (fixed)

"add torrent by URL" from web client

Reported by: arthus Owned by: charles
Priority: Normal Milestone: 1.50
Component: Web Client Version: 1.30
Severity: Normal Keywords:
Cc:

Description

When I try to upload a torrent in the web client (by url), it does nothing and logs this error to the console:

transmission.remote.addTorrentByURL is not a function
confirmUploadClicked(Object originalEvent=Event click which=1 view=window)transmission.js (line 503)
(?)()jquery.min.js (line 229)
(?)()jquery.min.js (line 202)
[Break on this error] transmission.remote.addTorrentByURL();

The culprit appears to be a commented out function at line 503 of transmission.remote.js

Change History (17)

comment:1 Changed 12 years ago by charles

  • Milestone changed from 1.31 to None Set

comment:2 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.32
  • Owner changed from Gimp to charles
  • Status changed from new to assigned
  • Summary changed from In web client, transmission.remote.addTorrentByURL is not a function to remove "add torrent by URL" from web client

The "Add by URL" feature is probably going to be removed from the web client because we're trying to keep the RPC protocol to the backend defined in such a way that responses can always be returned instantly. If the backend has to download a URL, that's not possible anymore.

Hijacking this ticket appropriately. :)

comment:3 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

removed in r6452.

comment:4 Changed 12 years ago by charles

  • Milestone changed from 1.32 to 1.50
  • Resolution fixed deleted
  • Status changed from closed to reopened

Popular demand indicates that this feature should return at some point. :)

comment:5 Changed 12 years ago by charles

  • Summary changed from remove "add torrent by URL" from web client to "add torrent by URL" from web client

comment:6 Changed 12 years ago by charles

  • Type changed from Bug to Enhancement

comment:7 Changed 12 years ago by irae

I'm just addimg a comment.

This feature is a must have, in my opinion.

Also, and the primary reason for my comment is to note for the developer that the iPhone version could only have a way to add a torrent via this feature plus an bookmarklet.

It could work as follow: 1 - User is instructed via help or some other way how can he create a bookmarklet in iPhone to adding torrents via iPhone interface. 2 - User navigate to a page (say, mininova.org) witch has an torrent link. 3 - User clicks on bookmarklet to activate it, javascript does some magic. 4 - An icon or an entire interface to add torrent is presented, but it is still on the website. Not the web client. 5 - The link finally directs the user to something like: http://111.222.333.444:5555/transmission/web/add_by_url?url=http://site.hold.com/torrentfile.torrent

If the user has an static IP this is fine. If it has dyndns the bookmarklet creator could have this option.

comment:8 Changed 12 years ago by kentyman

I too would like this functionality, so that I can create an iPhone bookmarklet just like I did for uTorrent, which can be found here:

http://forum.utorrent.com/viewtopic.php?id=38228

I understand it's annoying that this call can't return "instantly" like the others, but I feel that the ability to serve platforms like the iPhone is more important.

comment:9 Changed 12 years ago by charles

The feature has already been slated for 1.50. If you want it to get here any faster, submit a patch. ;)

comment:10 Changed 12 years ago by charles

  • Milestone changed from 1.50 to 1.60

comment:11 Changed 12 years ago by charles

r7744 gets us a lot closer: the RPC backend now supports adding torrents by specifying a URL.

comment:12 Changed 12 years ago by charles

  • Milestone changed from 1.60 to 1.50

comment:13 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

duncanbeevers' r7762 finishes what r7744 started :)

comment:14 Changed 12 years ago by kentyman

It's working great for me. If anyone wants to use the bookmarklet I mentioned above that uses this feature, you can find it here: http://forum.transmissionbt.com/viewtopic.php?f=8&t=6937

comment:15 Changed 12 years ago by kentyman

I'm actually having some problems using this with private trackers.

The torrent-add doesn't work with grabthe.info, probably due to some login issue. But more importantly, it consistently crashes when I try to torrent-add from xtremewrestlingtorrents.net.

Should this be reopened?

comment:16 Changed 12 years ago by kentyman

The crash might be related to this post, which says that Transmission crashes when two ampersands are passed:

http://forum.transmissionbt.com/viewtopic.php?f=8&t=6937&sid=56056923e0841b0cc6865ace034df457&start=15#p34111

comment:17 Changed 12 years ago by kentyman

I made a new ticket #1797 to handle this crash.

Note: See TracTickets for help on using tickets.