Opened 14 years ago
Closed 12 years ago
#1188 closed Bug (fixed)
comments and announce address are cut off
Reported by: | etsuffer | Owned by: | kjg |
---|---|---|---|
Priority: | Low | Milestone: | 1.70 |
Component: | Web Client | Version: | 1.32 |
Severity: | Minor | Keywords: | patch-needed |
Cc: |
Description
If a comment, an anounce url or an error is too long it doesn't unwrap text and you can see only a part of it
Screenshot added
And is that alright that announce url begins with '/'?
It would be good too if urls in comment will be replaced by links
Attachments (1)
Change History (12)
Changed 14 years ago by etsuffer
comment:1 Changed 14 years ago by livings124
- Summary changed from comments and other info are displayed not correctly to comments and announce address are cut off
comment:2 Changed 14 years ago by etsuffer
I actually said that it would be good to replace urls in comments, not in announce url =)
comment:3 Changed 14 years ago by j5osx
This is a matter of browser implementation of text-wrapping. Some browsers do not consider a / an appropriate place to break a line of text, while others do. This can be fixed by processing the announce url and replacing / with /<wbr/>, see:
comment:4 Changed 14 years ago by charles
- Keywords patch-needed added
comment:5 Changed 14 years ago by kjg
- Owner changed from Gimp to kjg
- Status changed from new to assigned
comment:6 Changed 14 years ago by kjg
- Resolution set to fixed
- Status changed from assigned to closed
fixed in r8428
comment:7 Changed 14 years ago by charles
- Milestone changed from None Set to 1.62
comment:8 Changed 14 years ago by charles
- Milestone changed from 1.62 to 1.70
Looks like we're going straight from 1.61 to 1.70...
comment:9 Changed 12 years ago by jordan
The fix in r8428 has the unfortunate side-effect that it makes URLs in the comments impossible to copy and paste to the URL bar in a browser, as reoprted in #4368.
An alternative fix would be to use "word-wrap: break-word;" in the css for inspector_row > div. This seems to not work on Chrome unless I remove the "display: table-cell;" setting in the same css section. That doesn't seem to have any ill effect on FF or Chrome.
Committing the word-wrap change to trunk. Could someone running Safari confirm that the inspector's columns still look the same after this change?
comment:10 Changed 12 years ago by jordan
- Resolution fixed deleted
- Status changed from closed to reopened
committed in r12573
comment:11 Changed 12 years ago by livings124
- Resolution set to fixed
- Status changed from reopened to closed
I am still seeing this with the announce url, but not with comments anymore.
The / in announce address is fixed in #1232.
I'm not sure if replacing tracker urls with links makes sense: there's usually not much to see at the announce address.