Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1267 closed Bug (fixed)

when making new torrents, don't allow 0-byte files

Reported by: IUG Owned by: charles
Priority: Normal Milestone: 1.40
Component: libtransmission Version: 1.33
Severity: Normal Keywords:
Cc:

Description

If you are trying to build a .torrent file in OS X of a folder that has a pasted icon on the folder, some sites might report the torrent as broken. I have tested this on a certain pirate site, after uploading the .torrent created from a folder with a custom icon. After it failed I went and deleted the icon file using the Terminal, created the torrent again, and it uploaded perfectly fine.

If you need me to go into more detail, I can. But this is easily recreated, at least on that site.

Change History (11)

comment:1 follow-up: Changed 13 years ago by livings124

Did you add this icon before or after creating the torrent file?

comment:2 in reply to: ↑ 1 Changed 13 years ago by IUG

Replying to livings124:

Did you add this icon before or after creating the torrent file?

Before. It's not a matter of not being able to seed, the torrent file won't upload to the site.

comment:3 follow-up: Changed 13 years ago by livings124

What error do you get when uploading?

comment:4 in reply to: ↑ 3 Changed 13 years ago by IUG

Replying to livings124:

What error do you get when uploading?

Depends on the website. It seems to build fine as far as the program's concerned. But when I try to upload it to a website it tells me that the torrent file seems to be broken/corrupted.

comment:5 Changed 13 years ago by livings124

  • Milestone changed from None Set to 1.40

The image for the icon appears to be 0 bytes, which is causing the problem.

comment:6 Changed 13 years ago by charles

  • Component changed from Transmission to Mac Client
  • Owner set to livings124

comment:7 Changed 13 years ago by livings124

  • Component changed from Mac Client to libtransmission
  • Owner changed from livings124 to charles

This is an issue with libtransmission adding 0 byte files, which it should not do (percent for these 0-byte files appear as -100%)

comment:8 Changed 13 years ago by charles

  • Keywords icon broken torrent custom removed
  • Status changed from new to assigned
  • Summary changed from Torrent fails to build if folder has a custom icon (.Icon) in OS X to when making new torrents, don't allow 0-byte files

comment:9 Changed 13 years ago by charles

  • Keywords backport-candidate added
  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in r6808

comment:10 Changed 13 years ago by charles

fix committed to 1.3x branch in r7280.

comment:11 Changed 12 years ago by charles

  • Keywords backport-candidate removed
Note: See TracTickets for help on using tickets.