leave the desktop's hibernation settings alone unless the user says otherwise

[godlygeek]

By default, Transmission is now set to inhibit hibernation. Unfortunately, this code also kicks in when gnome-power-manager blanks the screen, for example on a laptop lid close. To me, it seems that Transmission shouldn't be set to inhibit hibernation in the first place: Either the user asked the machine to hibernate, in which case he probably knew that Transmission was running and chose to hibernate anyway, or the machine was hibernating itself, for instance because of a low battery. In either of these cases, inhibiting hibernation is probably a bad idea. I don't think that disabling hibernation is a good idea for any desktop app, really.

[charles]

Desktop hibernation has a long ticket history here in trac:

​Transmission inhibits screen blanking as well as hibernation

​don't inhibit power management when manually triggering suspend or hibernate

​don't inhibit power management when torrents are paused

​(gtk) should not inhibit Sleep/Suspend

​inhibit/prevent hibernation when downloading

After the first ticket that requested inhibition, there have been four tickets asking for it to not inhibit in this case or that case. There have been similar posts in the forums and in IRC. Overall the current behavior -- that is, inhibiting hibernation by default -- seems to be violating the principle of least surprise.

Probably the best thing to, then, is to change our hibernation defaults to be something less suprising. We should allow hibernation by default, have an option to inhibit hibernation iff there are active torrents.

[charles]

fixed in r6870.