Changes between Initial Version and Version 5 of Ticket #1387


Ignore:
Timestamp:
Nov 3, 2008, 5:21:02 PM (12 years ago)
Author:
charles
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1387

    • Property Status changed from new to closed
    • Property Keywords backport-candidate added
    • Property Resolution changed from to fixed
    • Property Priority changed from Normal to High
  • Ticket #1387 – Description

    initial v5  
    77_tr_block() takes up 2.1% in refillPulse(), but can be removed.
    88
    9 The biggie is the overhead being used to create the strings for tr_deepLog().  It's not very expensive in any place that it's called, but is showing up at a little over 1% in a dozen different places.  We should add a check to see if deep logging is enabled ''before'' creating those strings.
     9tr_buildPath() is taking up a little over 3% by calling vsnprintf().  printf() is overkill here, since no string formatting is necessary -- we can simply malloc the path and  memcpy the path fragments.
     10
     11The biggie is the overhead being used to create the strings for tr_deepLog().  It's not very expensive in any place that it's called -- only a little over 1% in any given place -- but shows up in over a dozen places, so the cumulative footprint is large.  We can avoid all of that by checking to see if deep logging is enabled ''before'' creating those strings.