Opened 12 years ago

Closed 12 years ago

#1398 closed Enhancement (invalid)

don't accept incoming peer connections when all torrents are paused

Reported by: kocm Owned by: charles
Priority: Normal Milestone:
Component: libtransmission Version: 1.34
Severity: Minor Keywords: patch
Cc:

Description (last modified by charles)

I have transmission (6939) installed. After app start all torrents are paused, but sometimes transmission downloads and uploads some data. It updates information about torrent from tracker althougр torrent is paused. I think in this case program should not generate any traffic.

Attachments (2)

tr.png (92.3 KB) - added by kocm 12 years ago.
screenshot
paused-handshake.diff (3.3 KB) - added by charles 12 years ago.
patch to shun incoming handshakes iff there are no non-paused torrents

Download all attachments as: .zip

Change History (13)

Changed 12 years ago by kocm

screenshot

comment:1 Changed 12 years ago by charles

  • Description modified (diff)
  • Resolution set to invalid
  • Status changed from new to closed
  • Summary changed from strange transmission activity to network activity even when all torrents are paused

From the screenshot, it looks like one or more of these torrents had been active before they were all paused. During that time the tracker gave your address to other peers, who kept that information and are now trying to handshake with you.

comment:2 Changed 12 years ago by charles

  • Resolution invalid deleted
  • Status changed from closed to reopened

Hm. Though, in the special case of all torrents being paused, we should shun those incoming connections.

Changed 12 years ago by charles

patch to shun incoming handshakes iff there are no non-paused torrents

comment:3 Changed 12 years ago by charles

  • Component changed from Transmission to libtransmission
  • Milestone changed from None Set to 1.50
  • Severity changed from Normal to Minor

comment:4 Changed 12 years ago by charles

  • Keywords patch added

comment:5 Changed 12 years ago by charles

  • Version changed from 1.34+ to 1.34

comment:6 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Summary changed from network activity even when all torrents are paused to don't accept incoming peer connections when all torrents are paused
  • Type changed from Bug to Enhancement

added in r7239

comment:7 Changed 12 years ago by charles

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:8 Changed 12 years ago by charles

  • Owner set to charles
  • Status changed from reopened to new

comment:9 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from new to closed

comment:10 Changed 12 years ago by charles

  • Milestone 1.50 deleted
  • Resolution fixed deleted
  • Status changed from closed to reopened

This has been backed out of 1.5x and trunk due to #1810. By accepting these connections, we can clean them out and close them properly. I probably could write extra code to close them out as they come in, but it's not really worth the extra complexity -- after all, most people won't be running a torrent-less Transmission very often.

comment:11 Changed 12 years ago by charles

  • Resolution set to invalid
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.