Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#1400 closed Enhancement (fixed)

tracker warnings confuse the queue

Reported by: jh Owned by: charles
Priority: Normal Milestone: 1.74
Component: Mac Client Version: 1.34
Severity: Normal Keywords:
Cc:

Description

If a tracker doesn't respond libtransmision set the http code to 0. This is an error state and that will make transmission to mark the torrent as inactive internally.

But if this torrent is an active torrent and there are connected peers, the torrent will continue to seed and download.

The problem is that since the torrent is marked inactive a new torrent from the queue will be activated and transmission is now over the legal limit of active torrents.

Attachments (1)

tracker-errors.diff (11.7 KB) - added by charles 12 years ago.
first draft adding this feature and #2308. still needs mac code from bmw and web client proofreading from kjg

Download all attachments as: .zip

Change History (14)

comment:1 Changed 13 years ago by livings124

  • Component changed from Transmission to libtransmission
  • Owner set to charles
  • Type changed from Bug to Enhancement

I think the only way to fix this, especially in regards to the queue, is to differentiate "fatal" errors and warnings.

comment:2 Changed 13 years ago by charles

  • Milestone changed from None Set to 1.41
  • Status changed from new to assigned
  • Version changed from 1.34+ to 1.34

IMO this change is too low-level to put in as a last-minute before 1.40.

comment:3 Changed 13 years ago by charles

  • Milestone changed from 1.41 to 1.50

comment:4 Changed 13 years ago by livings124

  • Summary changed from if tracker doesn't respond, the torrent is seen as inactive but is not to differentiate between critical errors and warnings

comment:5 Changed 13 years ago by charles

  • Milestone changed from 1.50 to 1.60

comment:6 Changed 13 years ago by livings124

  • Milestone changed from 1.60 to 1.70

comment:7 Changed 12 years ago by charles

  • Milestone changed from 1.70 to Sometime

Changed 12 years ago by charles

first draft adding this feature and #2308. still needs mac code from bmw and web client proofreading from kjg

comment:8 Changed 12 years ago by charles

Note that the "inactive" part of this in the OP's message is not covered in the patch, since that's part of the mac client's code.

comment:9 Changed 12 years ago by charles

  • Milestone changed from Sometime to 1.74
  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in r8870, r8873

comment:10 Changed 12 years ago by charles

  • Summary changed from differentiate between critical errors and warnings to distinguish between between errors and warnings

comment:11 Changed 12 years ago by livings124

  • Summary changed from distinguish between between errors and warnings to distinguish between errors and warnings

comment:12 Changed 12 years ago by charles

  • Component changed from libtransmission to Mac Client
  • Summary changed from distinguish between errors and warnings to http errors during tracker announce confuses the queue

comment:13 Changed 12 years ago by livings124

  • Summary changed from http errors during tracker announce confuses the queue to tracker warnings confuse the queue
Note: See TracTickets for help on using tickets.