Opened 12 years ago

Closed 12 years ago

#1417 closed Bug (fixed)

Don't display protocol overhead in the speed monitor

Reported by: Shutnik Owned by: charles
Priority: Normal Milestone: 1.40
Component: libtransmission Version: 1.34+
Severity: Normal Keywords:
Cc:

Description

see attacher screenshot transmission 1.40b1

Attachments (1)

bug.png (9.4 KB) - added by Shutnik 12 years ago.

Download all attachments as: .zip

Change History (16)

Changed 12 years ago by Shutnik

comment:1 Changed 12 years ago by Shutnik

  • Component changed from Transmission to GTK+ Client
  • Owner set to charles
  • Priority changed from Normal to High

comment:2 Changed 12 years ago by livings124

  • Resolution set to invalid
  • Status changed from new to closed

Transmission now show BitTorrent? protocol overhead. Some might still occurred if torrents were recently paused, or if they're scraping.

comment:3 Changed 12 years ago by Shutnik

  • Resolution invalid deleted
  • Status changed from closed to reopened

I does not download anything today, but this downloading speed displays all the time

ok, it's just protocol overhead, but why it is not appends to total and/or session transfer statistic? if there is possibility does not appends it to statistic, why not disable it entirely (or do optionally)? it is wrong and terrible

comment:4 Changed 12 years ago by charles

You're right, it should be counted in the cumulative stats. Some users look at those stats to see how much of their ISP's bandwidth allotment has been used, so it makes sense to record the overhead there too.

comment:5 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

it's counted in the cumulative statistics now, as of r7039

comment:6 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.40
  • Priority changed from High to Normal
  • Summary changed from displays downloading speed with 0 downloading torrents to protocol overhead is shown in the speed monitor, but not in the global statistics

comment:7 Changed 12 years ago by livings124

  • Component changed from GTK+ Client to libtransmission

comment:8 Changed 12 years ago by livings124

  • Resolution fixed deleted
  • Status changed from closed to reopened

If anything, the overhead should be stored separately, even if they are added together when displayed. With this change you lose the ability to know how much data you've actually transferred, and once this goes into the release version there's no going back, ever. This is information I would be quite interested in, considering this value is what ratios should be based off of.

comment:9 Changed 12 years ago by charles

Yes, that's a good point too, and outweighs Shutnik's complaint IMO. reverted in r7042.

comment:10 Changed 12 years ago by charles

  • Resolution set to invalid
  • Status changed from reopened to closed

comment:11 Changed 12 years ago by charles

  • Summary changed from protocol overhead is shown in the speed monitor, but not in the global statistics to displays downloading speed with 0 downloading torrents

comment:12 Changed 12 years ago by charles

  • Milestone 1.40 deleted

comment:13 Changed 12 years ago by Shutnik

  • Resolution invalid deleted
  • Status changed from closed to reopened

yes, for count ratio this data should not be used, but it is real traffic what I download.

may be still store it separately (or not display this protocol overhead quite)?

comment:14 Changed 12 years ago by charles

  • Milestone set to 1.40
  • Summary changed from displays downloading speed with 0 downloading torrents to Don't display protocol overhead in the speed monitor

I'm not enthusiastic about this ticket, but it seems to be the consensus....

comment:15 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed as of r7060

Note: See TracTickets for help on using tickets.