Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#1432 closed Enhancement (fixed)

Pause torrent when verifying

Reported by: eisa01 Owned by: charles
Priority: Normal Milestone: 1.70
Component: libtransmission Version: 1.40
Severity: Normal Keywords:
Cc: eisa01, zachrait@…

Description

As you can see in this image, Transmission doesn't pause an already downloading file if you choose to verify the local data. This slows down the process, and I guess can lead to waste of data.

This should also apply any other torrents you have chosen to verify, they should pause and wait until it's their time.

Running 1.40b1

Attachments (3)

pic.png (222.8 KB) - added by eisa01 13 years ago.
fix.diff (1.8 KB) - added by zach 12 years ago.
Proposed fix
propfix.diff (1.2 KB) - added by zach 12 years ago.

Download all attachments as: .zip

Change History (19)

Changed 13 years ago by eisa01

comment:1 Changed 13 years ago by eisa01

  • Cc eisa01 added

comment:2 Changed 13 years ago by smmalis

I don't really like this idea, since it slows down the process of downloading the torrent. Is there really any downside to verifying and downloading at the same time?

comment:3 Changed 13 years ago by eisa01

This is something I discovered in connection with bug #1430

In that use case, this is wasted data. And you don't lose much download time anyway, but you can download a lot of data depending on your connection. Therefore I think this is better behaviour.

comment:4 Changed 13 years ago by charles

smmalis: if you don't know what you have and don't have, (1) how can you give peers accurate information about it, and (2) how do you know you're not downloading something you already have?

comment:5 Changed 13 years ago by charles

  • Component changed from Transmission to libtransmission
  • Milestone changed from None Set to 1.50
  • Owner set to charles
  • Status changed from new to assigned

I think this is a good idea, but I don't feel comfortable making this change so close to 1.40. Marking as `accepted', and provisionally aiming for 1.50, but maybe we can revise this to one of the 1.4x bugfix releases.

comment:6 Changed 13 years ago by charles

  • Milestone changed from 1.50 to 1.60

comment:7 Changed 13 years ago by charles

  • Version changed from 1.34+ to 1.40

comment:8 Changed 13 years ago by charles

  • Milestone changed from 1.60 to 1.70

re-bumped.

comment:9 Changed 12 years ago by zach

  • Cc zachrait@… added

Hi -- I'm new to helping out with Transmission and am not sure exactly how to propose a fix, but here's a diff that solves the problem for me (had to edit libtransmission to actually pause torrent as well as the OS X client to fix filtering to check whether it was actively checking instead of just waiting to verify). How do I actually become a contributing member? I'm interested in getting active in Transmission development.

Changed 12 years ago by zach

Proposed fix

comment:10 Changed 12 years ago by charles

zach: I think maybe that diff is incomplete? it's just a one-liner from the macosx directory, but you said you made changes to libtransmission as well?

comment:11 Changed 12 years ago by livings124

charles: there's libtransmission stuff in the patch too

comment:12 Changed 12 years ago by charles

wtf? you're right. maybe there's a bug in kompare... when I opened the diff, this is all it gave: http://imgur.com/JH0.png

Changed 12 years ago by zach

comment:13 Changed 12 years ago by zach

I think it was actually some sort of problem with the formation of my diff - I've recreated it and re-upped it and now it seems to be fine...

comment:14 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in r8389

comment:15 Changed 12 years ago by charles

  • Milestone changed from 1.70 to 1.62

IMO this should be backported if we ever do 1.62

comment:16 Changed 12 years ago by charles

  • Milestone changed from 1.62 to 1.70

Looks like we're going straight from 1.61 to 1.70...

Note: See TracTickets for help on using tickets.