Opened 12 years ago

Closed 12 years ago

#1435 closed Enhancement (fixed)

Web UI should allow selective downloading and file prioritization

Reported by: duncanbeevers Owned by: Gimp
Priority: Normal Milestone: 1.60
Component: Web Client Version: 1.34
Severity: Normal Keywords: web clutch file selection
Cc: kevin@…

Description

Should support displaying files associated with multiple selected torrents.

Attachments (8)

per-file-prioritization-for-web-ui.diff (18.4 KB) - added by duncanbeevers 12 years ago.
per-file-prioritization-for-web-ui.2.diff (24.6 KB) - added by duncanbeevers 12 years ago.
Updated initialization of Torrent to initialize corresponding TorrentFiles?
per-file-prioritization-for-web-ui.3.diff (26.5 KB) - added by duncanbeevers 12 years ago.
0001-allow-inspector-to-scroll.patch (1.5 KB) - added by kjg 12 years ago.
Enable scrolling in the inspector area
0002-fix-file-priorities-in-Safari.patch (1009 bytes) - added by kjg 12 years ago.
Allow the latest prioritization patch to work in safari
0003-hide-file-list-when-the-torrent-is-removed.patch (690 bytes) - added by kjg 12 years ago.
Hide the file listing on torrents as the get removed
0004-fix-new-torrent-file-refreshing.patch (1.5 KB) - added by kjg 12 years ago.
Fix new remote torrent file refreshing
squshed-all-web-priority-patches.patch (28.8 KB) - added by kjg 12 years ago.
squash all patches into one all inclusive patch

Download all attachments as: .zip

Change History (23)

Changed 12 years ago by duncanbeevers

comment:1 Changed 12 years ago by duncanbeevers

Limited polling for file updates, 1 in 10 periodic polls refreshes files info. Changing file priority or wantedness updates files. Gave periodical state via local closure.

comment:3 Changed 12 years ago by Gimp

  • Keywords web clutch file selection added
  • Milestone changed from None Set to 1.41
  • Status changed from new to assigned

Hey, alright, this will be going into svn right after 1.40 is released (I'm afraid this came a bit too late to make it into 1.4 [no time for serious testing])

I'll be going over this patch soon, and will note any things that need to be added to it.

comment:4 Changed 12 years ago by livings124

  • Milestone changed from 1.41 to 1.50

New features should wait for the next major release.

comment:5 Changed 12 years ago by duncanbeevers

Still need to implement creating file list for newly-added torrents.

Changed 12 years ago by duncanbeevers

Updated initialization of Torrent to initialize corresponding TorrentFiles?

Changed 12 years ago by duncanbeevers

comment:6 Changed 12 years ago by muczy

I'm using the third patch with 1.40. The only problem, I found, is that, there is no scrollbar, which is a must, with a multifile torrent.

comment:7 Changed 12 years ago by robinhood23rus

  • Version changed from 1.34 to 1.42

Using third path on 1.42 works well, but there are two things that I can't live without. Scrollbar and grouping files by folders. Scrollbar fast fix in change common.css (line 499) to

div#torrent_inspector {
background-color:#DDDDDD;
border-left:1px solid #888888;
bottom:22px;
overflow-x:hidden;
overflow-y:auto;
position:fixed;
right:0;
text-align:left;
top:97px;
width:350px;
z-index:2;
}

just two lines with overflow property. But as for grouping files by folders it would be much preferred because I have torrents with 10+ folders and 25+ files in each. It quite annoying to click all files when I need to turn off couple of folders. Same for priority.

comment:8 Changed 12 years ago by livings124

  • Version changed from 1.42 to 1.34

comment:9 Changed 12 years ago by charles

  • Milestone changed from 1.50 to 1.60

comment:10 Changed 12 years ago by itzy

:-( I was hoping this would make it into 1.50 (the sooner the better), since this is one vital feature when using torrents with a larger number of files in it.

Besides, this feature is working for me just fine (no scrollbars, though).

comment:11 Changed 12 years ago by robinhood23rus

Also I found that it is not a good idea to load files while loading list of torrents because of iPhone/iPod touch loading takes about 30-45 seconds to start while there are no way to manage files in "mobile" interface. In real browser it also works bit slower. May be it's all beacuse I have more than 20 torrents with lots of files in them. But if I have such problem then others could have. If duncanbeevers wouldn't mind then I can manage to fix this by the end of this week and may be this could be in 1.50 release.

comment:12 Changed 12 years ago by charles

  • Summary changed from Web Interface should allow selective downloading and prioritization of individual files. to Web UI should allow selective downloading and file prioritization

comment:13 Changed 12 years ago by kjg

  • Cc kevin@… added

I'm going to attach two patches. The first one is a more complete way to enable vertical scrolling in the inspector area. The second patch makes per-file-prioritization-for-web-ui.3 work in safari.

Changed 12 years ago by kjg

Enable scrolling in the inspector area

Changed 12 years ago by kjg

Allow the latest prioritization patch to work in safari

comment:14 Changed 12 years ago by kjg

Also I noticed that files aren't removed from the listing when the torrent is removed.

Changed 12 years ago by kjg

Hide the file listing on torrents as the get removed

Changed 12 years ago by kjg

Fix new remote torrent file refreshing

Changed 12 years ago by kjg

squash all patches into one all inclusive patch

comment:15 Changed 12 years ago by livings124

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.