Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1471 closed Enhancement (fixed)

better heuristics for which peers to unchoke

Reported by: charles Owned by: charles
Priority: Normal Milestone: 1.41
Component: libtransmission Version: 1.40
Severity: Normal Keywords:
Cc:

Description (last modified by charles)

In 1.3x and 1.40, the code that decides which peers to choke and unchoke uses the download speed from the peer to us as its primary key. This is an error since we choke/unchoke peers to indicate that we're interested in uploading to them, not downloading.

download speed could be used as a secondary key if we are concerned with tit-for-tat, but upload speed should be the primary concern.

Change History (6)

comment:1 Changed 12 years ago by charles

  • Component changed from Transmission to libtransmission
  • Owner set to charles
  • Status changed from new to assigned

comment:2 Changed 12 years ago by charles

  • Summary changed from upload speed should be more important when deciding which peers to keep to upload and download speeds should be equally important when deciding which peers to keep

comment:3 Changed 12 years ago by charles

  • Summary changed from upload and download speeds should be equally important when deciding which peers to keep to upload speed is not given enough weight when rechoking

comment:4 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

trunk: r7109, r7110

1.4x: r7116

comment:5 Changed 12 years ago by charles

  • Description modified (diff)
  • Summary changed from upload speed is not given enough weight when rechoking to better heuristics for which peers to unchoke

comment:6 Changed 12 years ago by charles

fix committed to 1.3x in r7285.

Note: See TracTickets for help on using tickets.