Opened 12 years ago

Closed 10 years ago

Last modified 10 years ago

#1477 closed Bug (fixed)

Launchpad translations need comment for strings with non-standard context

Reported by: Hew Owned by: charles
Priority: Normal Milestone: 2.40
Component: GTK+ Client Version: 2.33
Severity: Normal Keywords:
Cc: okram@…

Description

I did some en_AU translations which were identical to the en_US version, but they were in a strange format, eg. "filedetails|Download". I assumed they would be turned into "Download" by Transmission, so I should leave the translation in the same format as was given. I have just checked with Transmission 1.40 which includes my translations, and the strings are now displayed as "filedetails|Download" instead of "Download" as they were before, without a translation.

I opened a ticket at Launchpad Answers about the problem, and was told:

"That's sounds like glib's non-standard context support. Please file a bug against the project to at least add a translator comment for strings which use such non-standard behaviour explaining that people should remove context from translations."

Attachments (1)

removing context string.diff (42.4 KB) - added by okram 10 years ago.
Removes the context string "size|" from source and translation files.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 12 years ago by charles

  • Component changed from Transmission to GTK+ Client
  • Owner set to charles

comment:2 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.41
  • Status changed from new to assigned

comment:3 Changed 12 years ago by charles

Actually, looking over this code, I'm not sure why we have the context tags in there at all. None of those strings with context seem to be used anywhere else in the program...

comment:4 Changed 12 years ago by charles

  • Milestone changed from 1.41 to 1.42

I think the right thing to do is to remove the context tags from these strings... but I'm not positive about this and need to get some feedback from translators. Since we're so close to 1.41, and I don't want to break something at the last minute, I'm going to punt this to 1.42.

comment:5 Changed 12 years ago by charles

  • Milestone changed from 1.42 to 1.50
  • Resolution set to fixed
  • Status changed from assigned to closed

From what I'm hearing, it does make sense to remove the context component of the strings since those strings aren't used anywhere else. However this does break the string freeze, so I'm bumping to 1.50.

Committed to trunk in r7259.

comment:6 Changed 12 years ago by Hew

  • Resolution fixed deleted
  • Status changed from closed to reopened

There are two strings remaining with context:

speed|Down: %1$s, Up: %2$s Located in ../gtk/torrent-cell-renderer.c:120

size|Down: %1$s, Up: %2$s Located in ../gtk/tr-window.c:747 ../gtk/tr-window.c:758

comment:7 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

Good catch, thanks for pointing it out.

I've added a more descriptive comment to those lines in trunk in r7465.

Changed 10 years ago by okram

Removes the context string "size|" from source and translation files.

comment:8 Changed 10 years ago by okram

  • Cc okram@… added
  • Milestone changed from 1.50 to None Set
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version changed from 1.40 to 2.33+

This is a old bug, but it still persists. Even with the comments, the "size|" context string gets put where it doesn't belong and it often gets translated.

http://i.imgur.com/GVei0.png

I've included a patch (attached) which removes it from the source and translation files.

comment:9 Changed 10 years ago by jordan

  • Milestone changed from None Set to 2.34
  • Version changed from 2.33+ to 2.33

Thanks for the fix. I've applied the source code changes to trunk in r12592 for 2.40. The translation files must be handled upstream in Rosetta.

Last edited 10 years ago by jordan (previous) (diff)

comment:10 Changed 10 years ago by jordan

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:11 Changed 10 years ago by livings124

  • Milestone changed from 2.34 to 2.40
Note: See TracTickets for help on using tickets.