"transmission-remote -l" doesn't show Infinite ratio properly

[dzimi]

testbox (seeding):

debian:/storage/2008/11/27/1227794813# transmission-remote localhost:15365 -n 751:423986 -l
ID    Done  ETA       Up      Down    Ratio  Status       Name
   1  100%  Done       744.6     0.0    0.0  Seeding      NFSManager.dmg
debian:/storage/2008/11/27/1227794813# transmission-remote localhost:15365 -n 751:423986 -l
ID    Done  ETA       Up      Down    Ratio  Status       Name
   1  100%  Done       744.6     0.0    0.0  Seeding      NFSManager.dmg
debian:/storage/2008/11/27/1227794813# transmission-remote localhost:15365 -n 751:423986 -l
ID    Done  ETA       Up      Down    Ratio  Status       Name
   1  100%  Done       744.6     0.0    0.0  Seeding      NFSManager.dmg
debian:/storage/2008/11/27/1227794813# transmission-remote localhost:15365 -n 751:423986 -l
ID    Done  ETA       Up      Down    Ratio  Status       Name
   1  100%  Done         0.0     0.0    0.0  Idle         NFSManager.dmg
debian:/storage/2008/11/27/1227794813# transmission-remote localhost:15365 -n 751:423986 -l
ID    Done  ETA       Up      Down    Ratio  Status       Name
   1  100%  Done         0.0     0.0    0.0  Idle         NFSManager.dmg
debian:/storage/2008/11/27/1227794813# transmission-remote localhost:15365 -n 751:423986 -l
ID    Done  ETA       Up      Down    Ratio  Status       Name
   1  100%  Done         0.0     0.0    0.0  Idle         NFSManager.dmg
debian:/storage/2008/11/27/1227794813# transmission-remote localhost:15365 -n 751:423986 -l
ID    Done  ETA       Up      Down    Ratio  Status       Name
   1  100%  Done         0.0     0.0    0.0  Idle         NFSManager.dmg

On the second box (my mac :)) is running Transmission-1.40+ (r1762 too) - on the Mac ratio works. Seems like last when you did last changes you didn't upgraded deamon code :)

[dzimi]

Transmission Deamon screenshot

[dzimi]

Forgot to add, that on MAC i have run r7162 from nightly mac builds. On the debian box i have run transmission-svn7162.tar.bz2 from "Project trunk-linux-inc". Don't known way, but the version from Project trunk-linux-inc is showing as: r7104.

debian:~# transmission-daemon -h
Transmission 1.40+ (7104)  http://www.transmissionbt.com/
A fast and easy BitTorrent client

transmission-daemon is a headless Transmission session
that can be controlled via transmission-remote or Clutch.

Usage: transmission-daemon [options]

Options:
  -h --help                     Display this help page and exit
  -a --allowed      <list>      Allowed IP addresses.  (Default: 127.0.0.1)
  -b --blocklist                Enable peer blocklists
  -B --no-blocklist             Disable peer blocklists
  -f --foreground               Run in the foreground instead of daemonizing
  -g --config-dir   <path>      Where to look for configuration files
  -p --port         <port>      RPC port (Default: 9091)
  -t --auth                     Require authentication
  -T --no-auth                  Don't require authentication
  -u --username     <username>  Set username for authentication
  -v --password     <password>  Set password for authentication
  -w --download-dir <path>      Where to save downloaded data
debian:~# ls -l /usr/local/bin/transmission-daemon 
-rwxr-xr-x 1 root staff 1283820 2008-11-27 14:54 /usr/local/bin/transmission-daemon
debian:~# date
Thu Nov 27 15:34:07 CET 2008
debian:~#

Daemon was compliled compiled at 14:54 GTM+1

[charles]

trunk: r7163

1.4x: r7164

[KyleK]

There still seem to problems with the ratio display of transmission-remote.

One of my torrents has the following stats values:

"downloadedEver": 14447284783
"uploadedEver": 133928042

which results in "uploadRatio": "0.009270". But the remote displays the number "108" as ratio, which doesn't make sense at all.

Another torrent has these values:

"downloadedEver": 0
"uploadedEver": 1503164798
"uploadRatio": "-2.000000"

transmission-remote reports the ratio as "0.00", while it probably should be "Inf"

This was tested on the trunk, svn 7174.

I noticed that the ratio is calculated in multiple places, and even with some differences:

complection.c, tr_cpPercentDone:  tr_getRatio( cp->sizeNow, tr_cpSizeWhenDone( cp ) ); 
complection.c, tr_cpPercentComplete: tr_getRatio( cp->sizeNow, cp->tor->info.totalSize ); 
rpcimpl.c, addField: tr_getRatio( st->uploadedEver, st->downloadedEver ) );
stats.c, updateRatio: tr_getRatio( setme->uploadedBytes, setme->downloadedBytes );
torrent.c, tr_torrentStat: tr_getRatio(s->uploadedEver, s->downloadedEver ? s->downloadedEver : s->haveValid ); 

And to top it all of, daemon/remote.c calculates its own ratio. Wouldn't it be easier to add the "uploadedRatio" to list_keys[] and use that instead?

On a side note, I personally prefer the way tr_torrentStat calculates the ratio: if there has been no download (just seeding), then use the file size as denominator.

[charles]

KyleK: that's a good idea.

trunk: r7201

1.4x: r7202