#1527 closed Bug (fixed)
don't send pex messages if we don't have any new information to send
| Reported by: | charles | Owned by: | charles |
|---|---|---|---|
| Priority: | Normal | Milestone: | 1.41 |
| Component: | libtransmission | Version: | 1.40 |
| Severity: | Major | Keywords: | |
| Cc: |
Description
Short summary
If there isn't any change in the peer list, don't send a pex message. It's wasted bandwidth and µTorrent treats it as an error and disconnects.
Details
When doing a controlled test between Transmission r7167 and µTorrent 1.8.1, in a public swarm with just those two peers, µTorrent consistently gave "invalid packet length" errors and disconnected right after Transmission sent its second pex message. Since the swarm had reached steady state by then, the second pex message had no new content. This is wasted bandwidth, and µTorrent seems to treat it as a bug.
To confirm this, µTorrent's pex messages were observed in the same swarm. It sent one on startup, of course, and then didn't send any more until five minutes later after another tester joined the swarm.
Change History (4)
comment:1 Changed 12 years ago by charles
- Owner set to charles
- Status changed from new to assigned
comment:2 Changed 12 years ago by charles
- Resolution set to fixed
- Status changed from assigned to closed
comment:3 Changed 12 years ago by livings124
- Component changed from Transmission to libtransmission
comment:4 Changed 12 years ago by charles
fix committed to 1.3x in r7283
1.4x: r7168 trunk: r7169