Opened 12 years ago
Closed 10 years ago
#1538 closed Enhancement (fixed)
Make Web UI URL configurable
Reported by: | wereHamster | Owned by: | wereHamster |
---|---|---|---|
Priority: | Normal | Milestone: | 2.20 |
Component: | Web Client | Version: | 1.91 |
Severity: | Normal | Keywords: | web, proxy |
Cc: | tom@…, seiichiro0185@…, alexandre.rossi@… |
Description
The Web UI URL (/transmission/web) is currently hardcoded in several places (C, JavaScript code). This makes it impossible to configure a http-server as a proxy for more then one transmission daemon (at least not without using some kind of reverse-proxy that rewrites the URLs in the response). It would be nice to make the Web URL configurable.
Attachments (7)
Change History (28)
comment:1 Changed 12 years ago by charles
comment:2 Changed 12 years ago by charles
- Milestone changed from None Set to 1.50
- Owner changed from Gimp to charles
- Status changed from new to assigned
wereHamster: could you sync this patch with trunk?
comment:3 Changed 12 years ago by wereHamster
I changed the default to /, I think it makes more sense then /transmission/web - the web server runs on a separate port anyway. The rpc url is /rpc, so any scripts would need to be updated. If you don't like it, you can change the default in session.c. Just make sure it ends with a / (eg. /transmission/web/).
comment:4 Changed 12 years ago by charles
- Milestone changed from 1.50 to 1.60
comment:5 Changed 12 years ago by charles
05:10 < wereHamster> charles_: I won't have time in the next week to work on T (I _really_ should read the papers at least once before I turn up at the exams) 05:11 < wereHamster> so maybe you should to postpone 1538 until 1.60
comment:6 Changed 12 years ago by charles
- Resolution set to wontfix
- Status changed from assigned to closed
wereHamster: reopen this ticket when you think the patch is ready. I agree with the premise and will use the finished patch into svn.
Changed 12 years ago by wereHamster
Changed 12 years ago by wereHamster
comment:7 Changed 12 years ago by wereHamster
- Resolution wontfix deleted
- Status changed from closed to reopened
I updated the patches. The first one only changes javascript files, the second one contains the remaining changes. Unlike I said in comment 5, the default url is /transmission/ (thus won't break any existing scripts). Also, the handling of URLs changed slightly. If the url is .../rpc, it's handled by handle_rpc(), if the url is .../upload, it's handled by handle_upload(), else the url is handled by handle_clutch(). So there's no .../web url anymore. The downside of that is that it can't serve any files that start with 'rpc' or 'upload', but I don't think it's a big issue.
comment:8 Changed 12 years ago by livings124
- Milestone changed from 1.60 to Sometime
comment:9 Changed 12 years ago by charles
wereHamster: somehow I didn't notice that this ticket was reopened. If the patches are still good, let me know and I'll put them into trunk.
Changed 12 years ago by wereHamster
comment:10 Changed 11 years ago by charles
This ticket just keeps falling through the cracks.
wereHamster: is that latest revision ready for commiting?
comment:11 Changed 11 years ago by charles
This ticket just keeps falling through the cracks.
wereHamster: if this patch is ready please set the milestone @ 1.90
comment:12 Changed 11 years ago by wereHamster
I'll wait for you to commit a certain patch because it conflicts with my changes. Once you do so I'll update my two patchs and attach them here.
comment:13 Changed 11 years ago by seiichiro0185
- Cc seiichiro0185@… added
comment:14 Changed 11 years ago by wereHamster
- Version changed from 1.40 to 1.91
comment:15 Changed 10 years ago by niol
- Cc alexandre.rossi@… added
comment:16 Changed 10 years ago by niol
I've been running transmission with this patch for a week now, and it works great. Please let me know if I need to improve something for it to be merged.
comment:17 Changed 10 years ago by charles
- Milestone changed from Sometime to 2.20
comment:18 Changed 10 years ago by niol
I added the corresponding enhancement to the transmission-remote tool. I've made the change in a backward compatible way (i.e. command line with only host:port or host or port still work). Please tell me if I need to further fix things.
Changed 10 years ago by wereHamster
comment:19 Changed 10 years ago by wereHamster
ticket-1538-configurable-web-url.patch is freshly rebased on top of r11506. It contains all the needed changes (javascript, rpc-server and the remote).
comment:20 Changed 10 years ago by charles
- Owner changed from charles to wereHamster
- Status changed from reopened to new
added to trunk by r11524
comment:21 Changed 10 years ago by charles
- Resolution set to fixed
- Status changed from new to closed
I'd like to see #1559 get checked in first.