Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1539 closed Bug (fixed)

Win32 builds broken due to IPv6 support

Reported by: spry Owned by: charles
Priority: Normal Milestone: 1.50
Component: libtransmission Version: 1.40
Severity: Major Keywords: ipv6 libtransmission
Cc:

Description

Subject. Added patch at least gives ability to compile on win32, but I'm not sure if it will work for ipv6 systems..

Attachments (3)

win32_ipv6_compile.patch​ (11.2 KB) - added by spry 12 years ago.
win_net.c.diff​ (1.7 KB) - added by spry 12 years ago.
Valid patch
win-r7661.patch​ (27.6 KB) - added by spry 12 years ago.
Copy was sent to your email

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by spry

comment:1 Changed 12 years ago by charles

Spry: those strings are just being used for display purposes. Wouldn't it be simpler to use WSAAddressToString() instead?

Also I'm not sure what the copyright status of Paul Vixie's code is in that patch.

comment:2 Changed 12 years ago by spry

That is a draft patch. No, there is no his copyrights :) That is a miss of mine. Ok. But I'm not sure that can work with IPv6 WSAAddressToString. If it could, maybe CURL also used it. And also somewhere you use backwards convert, from string to address. How to be with that? I know some win32 functions, but they appeared only in Windows Vista..

Changed 12 years ago by spry

Valid patch

comment:3 Changed 12 years ago by jhujhiti

Does the latest patch still apply cleanly against trunk?

Changed 12 years ago by spry

Copy was sent to your email

comment:4 Changed 12 years ago by charles

  • Status changed from new to assigned

Fixed in trunk in r7663

comment:5 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.50
  • Resolution set to fixed
  • Status changed from assigned to closed

comment:6 Changed 12 years ago by charles

  • Priority changed from High to Normal
  • Severity changed from Normal to Major
Note: See TracTickets for help on using tickets.