Opened 12 years ago

Closed 12 years ago

#1560 closed Bug (fixed)

tr_strlsize() type conflict

Reported by: naddy Owned by: charles
Priority: Normal Milestone: 1.41
Component: GTK+ Client Version: 1.40
Severity: Normal Keywords:
Cc:

Description

gtk/util.h declares tr_strlsize() like this:

char*       tr_strlsize( char *   buf,
                         uint64_t size,
                         size_t   buflen );

gtk/util.c defines it like this:

char*
tr_strlsize( char *  buf,
             guint64 size,
             size_t  buflen )

This fails to compile on some systems because uint64_t and guint64 are not the same type. This can happen on 64-bit systems (I see it on OpenBSD/sparc64), where one of these types aliases "long" and the other one "long long", both of which are 64 bits long but not the same type as far as the compiler is concerned.

Fix: Use the same type in both the prototype declaration and the function definition.

Change History (2)

comment:1 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.41
  • Status changed from new to assigned
  • Version changed from 1.40+ to 1.40

comment:2 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

fix committed to 1.4x branch in r7270.

fix committed to trunk in 7271.

Note: See TracTickets for help on using tickets.