Opened 12 years ago

Closed 12 years ago

#1608 closed Enhancement (fixed)

Completed pieces bitfield in rpc

Reported by: Elbandi Owned by: charles
Priority: Normal Milestone: 1.60
Component: libtransmission Version: 1.41
Severity: Normal Keywords: PATCH
Cc:

Description

I added a little code, to get the complete pieces bitmask in rpc. I collect the bits to 64 bit long integer (instead of 8 bits), this makes less size in a big torrent.

Attachments (1)

complete-pieces.patch (3.4 KB) - added by Elbandi 12 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 follow-up: Changed 12 years ago by charles

What is this used for?

comment:2 in reply to: ↑ 1 Changed 12 years ago by Elbandi

Replying to charles:

What is this used for?

utorrent has a multiprogress bar: the big is for completed pieces and the little is for completed block. I want write same progressbar into transmission-remote-dotnet. Therefore i need to query the block status.

comment:3 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.60
  • Status changed from new to assigned

comment:4 Changed 12 years ago by charles

Elbandi: I'm ready to start doing the RPC changes for 1.60. If you'll refresh this patch s.t. it'll apply against trunk, I'll check it in.

Changed 12 years ago by Elbandi

comment:5 Changed 12 years ago by Elbandi

  • Keywords PATCH added

Updated.

comment:6 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

The bitfield's been added now in r7992.

I hope you don't mind the change, but the array of 64-bit integers seemed like a kind of random way of doing it. Instead, I ship the "pieces" bitfield out as a base64-encoded string.

Note: See TracTickets for help on using tickets.