Opened 12 years ago

Closed 12 years ago

#1634 closed Bug (fixed)

Torrents not using UTF-8 can really confuse Transmission

Reported by: mikronom Owned by: charles
Priority: Normal Milestone: 1.50
Component: libtransmission Version: 1.42
Severity: Normal Keywords:
Cc:

Description (last modified by charles)

I added a torrent found online

after upgrading to 1.42, and Transmission got terribly confused:

1) It shows the entry without name in the overview. 2) If I rightclick on it and select "Show inspector", it shows the inspector but says "Nothing selected". 3) If I rightclick and select "Remove Data File...", it removes *all* my downloaded files. Thanks bog for Trash. 4) When I rightclick in order to select a file to prioritize, it shows no file list (consistent with #2).

Change History (16)

comment:1 Changed 12 years ago by charles

  • Resolution set to invalid
  • Status changed from new to closed

The torrent violates the bittorrent spec by not using UTF-8 encoding.

comment:2 Changed 12 years ago by livings124

  • Resolution invalid deleted
  • Severity changed from Major to Normal
  • Status changed from closed to reopened

An invalid torrent like this should return TR_EINVALID for tr_torrentParse, not TR_EDUPLICATE.

comment:3 Changed 12 years ago by livings124

  • Component changed from Transmission to libtransmission

comment:4 Changed 12 years ago by charles

livings124: so you're suggesting that we reject any torrent that doesn't have UTF-8 encoding?

comment:5 Changed 12 years ago by livings124

I'm saying that adding a torrent like this causes libtransmission to fail with an inappropriate error. If libtransmission rejects a torrent that doesn't have UTF-8 encoding, it shouldn't say that the reason is because it's a duplicate - this is a clear bug in libtransmission.

comment:6 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.50
  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in trunk in r7657.

See also related ticket #1675, which was fixed in r7656

comment:7 Changed 12 years ago by charles

  • Summary changed from This torrent makes Transmission lose all bearings to Torrents not using UTF-8 can really confuse Transmission

comment:8 Changed 12 years ago by mikronom

If we're still on the subject, I'd like to hear if anyone has addressed the more troubling problem (no 3 in the initial report) that Transmission actually deletes all my downloaded files if I ask it to delete the files of this faulty torrent. I couldn't see the patch addressing it.

comment:9 Changed 12 years ago by charles

mikronom: I think your item no. 3 is handled in <http://trac.transmissionbt.com/ticket/1029>

comment:10 Changed 12 years ago by mikronom

Hey Charles, thanks for the follow-up! I've downloaded 1.50b5 now and it does take care of no. 3. Not in the way described by the other ticket, but in a way that's better and worse: instead of throwing away the entire torrent name (since it was badly encoded) it replaces the badly encoded parts with question marks. So now the torrent has a name ("VA-O, Helga Natt-Adams juls?ng"), and since it was the lack of a name that caused my troubles, I'm happy.

The (theoretical) downside is that it doesn't find the old files, so if I had been downloading, I would have had to start over again. I got all the files a long time ago, so no problem here.

Thanks for the support!

comment:11 Changed 12 years ago by charles

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:12 Changed 12 years ago by charles

  • Owner set to charles
  • Status changed from reopened to new

comment:13 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from new to closed

comment:14 Changed 12 years ago by charles

  • Description modified (diff)
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:15 Changed 12 years ago by charles

  • Status changed from reopened to new

comment:16 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.