Opened 12 years ago

Closed 12 years ago

#1643 closed Bug (fixed)

leftover dependency on CTGradient

Reported by: er13 Owned by: charles
Priority: Low Milestone:
Component: Mac Client Version: 1.42+
Severity: Minor Keywords:
Cc:

Description

Since r7509 transmission doesn't depend on CTGradient anymore. The corresponding dependency is however still present in macosx/Makefile.am.

This issue seems to break the automatic svn builds (see e.g. console log), the actual reason I'm reporting it :)

NB: the attached patch is untested

Attachments (2)

leftover_dependency_on_CTGradient-UNTESTED_FIX.diff (283 bytes) - added by er13 12 years ago.
more_leftover_dependencies.diff (757 bytes) - added by er13 12 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by charles

  • Milestone None Set deleted
  • Owner changed from livings124 to charles
  • Status changed from new to assigned

fixed in trunk in r7538. thanks for the patch.

comment:2 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:3 Changed 12 years ago by er13

I would also wish, that in case one specifies --disable-mac (--disable-gtk, --disable-nls and so on) the build system doesn't even try to change into the corresponding directory or to generate dummy Makefiles in it.

comment:4 Changed 12 years ago by er13

  • Resolution fixed deleted
  • Status changed from closed to reopened

it seems there are some more (compare with r7508):

ActionPopUpButton?.h ActionPopUpButton?.m MenuLabel?.h MenuLabel?.m NSApplicationAdditions.h NSApplicationAdditions.m NSBezierPathAdditions.h NSBezierPathAdditions.m

Changed 12 years ago by er13

comment:5 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

fixed in r7542. Thanks :)

Note: See TracTickets for help on using tickets.