Changes between Initial Version and Version 2 of Ticket #1734


Ignore:
Timestamp:
Jan 22, 2009, 2:34:08 PM (12 years ago)
Author:
charles
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1734

    • Property Status changed from new to assigned
    • Property Owner set to charles
  • Ticket #1734 – Description

    initial v2  
    1 Beginning back with Aloysius' `performance patch' submitted via the forums, Transmission has made a practice of buffering up non-critical BitTorrent protocol messages (like `have' and periodic pex messages) and sending them in a batch to reduce socket-level packet overhead.
     1Beginning back with the "performance patch" submitted by Aloisus via the forums, Transmission has made a practice of buffering up non-critical BitTorrent protocol messages (such as `have' and periodic pex messages) and sending them in a batch to reduce socket-level packet overhead.
    22
    33The bug is that these protocol messages are encrypted as they're written into the batch buffer.  If that is done, and then we encrypt and send piece data ''before'' the protocol messages batch is flushed, the order of the messages' encryption and the messages' transmission are reversed and the RC4 stream is corrupted.