Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1757 closed Enhancement (fixed)

make "open" button clearer in preference dialog's web tab

Reported by: WouterBolsterlee Owned by: charles
Priority: Normal Milestone: 1.50
Component: GTK+ Client Version: 1.40
Severity: Trivial Keywords:
Cc:

Description

The summary says it all: a web browser icon should be used on "Open" button in Web interface preference tab. Currently it looks like the button will open a file chooser dialog (which is does not).

Change History (15)

comment:1 Changed 12 years ago by WouterBolsterlee

  • Version changed from 1.42 to 1.40

comment:2 Changed 12 years ago by charles

  • Resolution set to wontfix
  • Status changed from new to closed

There is no stock web browser icon in GTK afaik

comment:3 Changed 12 years ago by WouterBolsterlee

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Well, that doesn't make using the wrong icon right.

Reopening this bug.

(Oh, and I consider it slightl, well, eh, unfriendly to close a valid report as WONTFIX without any prior discussion, but perhaps that's just me. I'm used to the way the Gnome community handles reports in Bugzilla, which is quite different from what I have seen on this Trac. Don't take offense, please.)

comment:4 Changed 12 years ago by WouterBolsterlee

Suggestion: use the label "Open web interface" on the button, since that is what the button does (this is not obvious), and don't use an icon.

comment:5 Changed 12 years ago by charles

Okay. From an abstract standpoint, IMO it's more important what the button does than how the button does it. Therefore the "help" aspect is more important than the "browser" aspect, so the "help" icon should be used.

Having no label plus "Open web interface" is worse than what we've got now. Every user will be able to guess that a "Help" button will open some sort of help window. IMO you will not get anywhere near that percentage with "open web interface".

But really the point here is that what the button does is more important than how the button does it. That's why the Help button should stay a help button, rather than getting tangled up in whether it's done via a browser or "web interface" or what.

comment:6 Changed 12 years ago by charles

(gah, I didn't mean to should through the last paragraph... I blame trac ;)

comment:7 Changed 12 years ago by charles

  • Severity changed from Normal to Trivial
  • Type changed from Bug to Enhancement

comment:8 Changed 12 years ago by charles

gah, I'm an idiot, please ignore comment #5 altogether.

comment:9 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.50
  • Summary changed from [GTK] Use web browser icon on "Open" button in Web interface preference tab to make "open" button clearer in preference dialog's web tab

committed to trunk in r7818

comment:10 Changed 12 years ago by WouterBolsterlee

  • Resolution set to fixed
  • Status changed from reopened to closed

Thanks, so at least the label on the button makes sense now, even though it's the wrong icon ;)

Fwiw, I couldn't find any reference in the HIG for this, only an assistent example dialog with a Find button, but no Find stock icon.

I'm marking this report fixed for now. Thanks again.

comment:11 Changed 12 years ago by charles

  • Resolution fixed deleted
  • Status changed from closed to reopened

I need to leave this open until I do the next mass backport to the 1.5x branch...

comment:12 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

backported to 1.5x in r7821

comment:13 Changed 12 years ago by WouterBolsterlee

  • Resolution fixed deleted
  • Status changed from closed to reopened

For some reason the newly introduced string is not available for translation on Launchpad. Any clue why? I'm looking at the trunk translation, according to Launchpad.

comment:14 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

Thanks very much for reopening this. I've uploaded a new transmission.pot to launchpad to resolve this. Launchpad's upload page says "It will be automatically reviewed in the next few hours."

comment:15 Changed 12 years ago by WouterBolsterlee

Charles, thanks for the prompt reply and action.

Note: See TracTickets for help on using tickets.