Opened 12 years ago

Closed 12 years ago

#1772 closed Enhancement (wontfix)

Mark all 'Done' torrents for process

Reported by: turbo Owned by: charles
Priority: Normal Milestone: None Set
Component: Daemon Version: 1.42
Severity: Normal Keywords: patch
Cc:

Description

I wanted to only move (#920) all 'Done' torrents, but I've left my daemon running for a couple of days without looking much on it - there's quite a large list of done's!

The fix could easily be extended for 'Seeding's etc...

Attachments (1)

transmission-mark_done.diff (1.1 KB) - added by turbo 12 years ago.
Get a list of all 'Done' torrents

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by turbo

Get a list of all 'Done' torrents

comment:1 Changed 12 years ago by turbo

  • Keywords patch added

comment:2 Changed 12 years ago by charles

Implementation complaint: "st->leftUntilDone == 0" should be enough; the ETA check can be omited.

Design complaint: I don't really see why filtering like this should be on the server side. If one state like this is allowed in, then there will be requests for all kinds of other server-side state filtering.

comment:3 Changed 12 years ago by turbo

Well, putting it in the client(s) would give a lot more code that is IMHO better suited for the daemon.

In the case of a 'move done' and this was in the client, the client needs to retreive a full list of all torrents, filter out all but done's, send a 'move torrent x' for each done.

And EACH client needs this! The Web, the GUI's etc. This way, it's in the lib where everyone can use it directly...

And yes, I agree - if not carefull, the daemon could be littered with this. But SOME filtering might be better suited for the daemon/lib...

comment:4 Changed 12 years ago by charles

  • Version changed from 1.42+ to 1.42

comment:5 Changed 12 years ago by charles

  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.