Opened 12 years ago
Closed 12 years ago
#1777 closed Enhancement (fixed)
Size column in transmission-remote
Reported by: | turbo | Owned by: | charles |
---|---|---|---|
Priority: | Normal | Milestone: | 1.50 |
Component: | Transmission | Version: | 1.42 |
Severity: | Normal | Keywords: | patch |
Cc: |
Description
I'd like to know how much that is/have been downloaded for each torrent.
Attachments (5)
Change History (16)
Changed 12 years ago by turbo
comment:1 Changed 12 years ago by Elbandi
i think this patch is not good: nobody free the size variable. Use static char string[100].
comment:2 Changed 12 years ago by turbo
- Keywords patch added
comment:3 Changed 12 years ago by charles
I don't see why this patch doesn't use strlsize(), which is already implemented in remote.c
Changed 12 years ago by turbo
Use strlsize() instead of homemade - sorry, didn't see it. Also not a pointer..
comment:4 Changed 12 years ago by charles
- Milestone changed from None Set to 1.50
- Owner set to charles
- Status changed from new to assigned
- Version changed from 1.42+ to 1.42
committed to trunk in r7819
comment:5 Changed 12 years ago by turbo
To illustrate:
pre-patch: ID Done Have ETA Up Down Ratio Status Name
1 100% 349.7 MB Done 0.0 0.0 0.12 Idle <torrent 1> 2 100% 702.5 MB Done 0.0 0.0 Inf Idle <torrent 2> 3 100% 84.0 MB Done 0.0 0.0 0.05 Idle <torrent 3> 4 100% 1.4 GB Done 3.6 0.0 0.04 Seeding <torrent 4> 5 100% 8.4 GB Done 0.0 0.0 0.28 Idle <torrent 5> 6 100% 358.2 MB Done 0.0 0.0 0.05 Idle <torrent 6> 7 100% 7.5 GB Done 0.0 0.0 0.03 Idle <torrent 7> 8 48% 17.1 GB 12 days 44.3 11.2 2.90 Up & Down <torrent 8> 9 98% 7.5 GB 21 hrs 0.0 2.0 0.01 Downloading <torrent 9>
after-patch: ID Done Have ETA Up Down Ratio Status Name
1 100% 349.7 MB Done 0.0 0.0 0.12 Idle <torrent 1> 2 100% 702.5 MB Done 0.0 0.0 Inf Idle <torrent 2> 3 100% 84.0 MB Done 0.0 0.0 0.05 Idle <torrent 3> 4 100% 1.4 GB Done 0.0 0.0 0.04 Seeding <torrent 4> 5 100% 8.4 GB Done 0.0 0.0 0.28 Idle <torrent 5> 6 100% 358.2 MB Done 0.0 0.0 0.05 Idle <torrent 6> 7 100% 7.5 GB Done 0.0 0.0 0.03 Idle <torrent 7> 8 48% 17.1 GB 22 days 42.0 10.0 2.90 Up & Down <torrent 8> 9 98% 7.5 GB 21 hrs 0.0 2.0 0.01 Downloading <torrent 9>
The header makes it look really ugly and the actuall Have info is justified right, but numbers should always (?) be justified left...
comment:6 Changed 12 years ago by turbo
crudd! Again:
pre-patch: ID Done Have ETA Up Down Ratio Status Name 1 100% 349.7 MB Done 0.0 0.0 0.12 Idle <torrent 1> 2 100% 702.5 MB Done 0.0 0.0 Inf Idle <torrent 2> 3 100% 84.0 MB Done 0.0 0.0 0.05 Idle <torrent 3> 4 100% 1.4 GB Done 3.6 0.0 0.04 Seeding <torrent 4> 5 100% 8.4 GB Done 0.0 0.0 0.28 Idle <torrent 5> 6 100% 358.2 MB Done 0.0 0.0 0.05 Idle <torrent 6> 7 100% 7.5 GB Done 0.0 0.0 0.03 Idle <torrent 7> 8 48% 17.1 GB 12 days 44.3 11.2 2.90 Up & Down <torrent 8> 9 98% 7.5 GB 21 hrs 0.0 2.0 0.01 Downloading <torrent 9> after-patch: ID Done Have ETA Up Down Ratio Status Name 1 100% 349.7 MB Done 0.0 0.0 0.12 Idle <torrent 1> 2 100% 702.5 MB Done 0.0 0.0 Inf Idle <torrent 2> 3 100% 84.0 MB Done 0.0 0.0 0.05 Idle <torrent 3> 4 100% 1.4 GB Done 0.0 0.0 0.04 Seeding <torrent 4> 5 100% 8.4 GB Done 0.0 0.0 0.28 Idle <torrent 5> 6 100% 358.2 MB Done 0.0 0.0 0.05 Idle <torrent 6> 7 100% 7.5 GB Done 0.0 0.0 0.03 Idle <torrent 7> 8 48% 17.1 GB 22 days 42.0 10.0 2.90 Up & Down <torrent 8> 9 98% 7.5 GB 21 hrs 0.0 2.0 0.01 Downloading <torrent 9>
comment:7 Changed 12 years ago by turbo
Dang, I wish I could EDIT/change a post!!
ID Done Have ETA Up Down Ratio Status Name 1 100% 349.7 MB Done 0.0 0.0 0.12 Idle <torrent 1> 2 100% 702.5 MB Done 0.0 0.0 Inf Idle <torrent 2> 3 100% 84.0 MB Done 0.0 0.0 0.05 Idle <torrent 3> 4 100% 1.4 GB Done 0.0 0.0 0.04 Seeding <torrent 4> 5 100% 8.4 GB Done 0.0 0.0 0.28 Idle <torrent 5> 6 100% 358.2 MB Done 0.0 0.0 0.05 Idle <torrent 6> 7 100% 7.5 GB Done 0.0 0.0 0.03 Idle <torrent 7> 8 48% 17.1 GB 9 days 63.2 23.3 2.90 Up & Down <torrent 8> 9 98% 7.5 GB 14 hrs 0.0 3.0 0.01 Downloading <torrent 9>
comment:8 Changed 12 years ago by charles
transmission-remote.2.diff committed in r7820.
comment:9 Changed 12 years ago by charles
- Resolution set to fixed
- Status changed from assigned to closed
backported to 1.5x in r7821.
comment:10 Changed 12 years ago by turbo
- Resolution fixed deleted
- Status changed from closed to reopened
Changed 12 years ago by turbo
If 'Have' is '<1024 && >999' then it's uggly (not correctly justified - the rest of the line pushed one char to much to the right. Fix: Replace '%8s' with '%9s'.
comment:11 Changed 12 years ago by charles
- Resolution set to fixed
- Status changed from reopened to closed
committed to trunk in r7835
Add 'Size' as fourth column (between ETA and Up)