Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1833 closed Enhancement (fixed)

Sum-total line of speed Up and Down colums, at the end of the transmission-remote -l report

Reported by: krx Owned by:
Priority: Lowest Milestone: 1.51
Component: Daemon Version: 1.51+
Severity: Trivial Keywords: up down speed sum report tranmission-remote
Cc:

Description

Hi,

It would be nice, if transmission-remote -l command would report sum of Up and Down speed columns at the end of the command line report.

Attachments (1)

remote_summary.patch (1.4 KB) - added by Elbandi 12 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 12 years ago by livings124

  • Milestone changed from 1.51 to None Set
  • Resolution set to invalid
  • Status changed from new to closed

This is bloat. They are two separate values, adding them together makes little sense.

And don't set milestones unless you are a developer/contributor.

comment:2 follow-up: Changed 12 years ago by krx

  • Resolution invalid deleted
  • Status changed from closed to reopened

Sorry, I meant two separate sums. One for Upload, other for Download. I did not mean sum of two sums.

comment:3 Changed 12 years ago by livings124

  • Component changed from Transmission to Daemon

Changed 12 years ago by Elbandi

comment:4 in reply to: ↑ 2 ; follow-ups: Changed 12 years ago by Elbandi

Do you think so?

comment:5 in reply to: ↑ 4 Changed 12 years ago by krx

Replying to Elbandi:

Do you think so?


If that was the question for me, and I have interpreted the code correctly, then yes ;-)

comment:6 in reply to: ↑ 4 Changed 12 years ago by krx

Replying to Elbandi:

Do you think so?

As I understand, this patch was proposed, and I do not have to monitor this thread any more, as some time in the future the patch will go into mainstream code? Thanks!

comment:7 follow-up: Changed 12 years ago by charles

I never agreed to put this into the mainstream code. :)

The patch is straightforward enough, but I'm a little uncomfortable with all the bells and whistles that have been added onto transmission-remote over the past few releases. It's not really meant to be a full-fledged client...

I haven't really made up my mind about this patch.

comment:8 in reply to: ↑ 7 Changed 12 years ago by krx

Replying to charles:

I never agreed to put this into the mainstream code. :)

The patch is straightforward enough, but I'm a little uncomfortable with all the bells and whistles that have been added onto transmission-remote over the past few releases. It's not really meant to be a full-fledged client...

I haven't really made up my mind about this patch.


Sorry, I do not know, who is responsible for planning. Because in bug-tickets I see input from various persons, I made assumption, that the development efforts are quite loose coordinated.

Regarding command line extension. There is a reason for this. I do not run WebClient? so often, because it steals I/O from the Transmission main process and both processes start to starve on CPU, and RAM also (32 MB is not so much on the router :-|).

If I have capability to use putty/telnet, I do so - it is faster. If not, I try to use WebClient? only for addition of torrents and quick glean on the status.When I was investigating issues with upload speed limit not being enforced, it was quite inconvenient to add digits of 40+ running torrents.

That was idea behind this asking ;-)

comment:9 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.51
  • Resolution set to fixed
  • Status changed from reopened to closed

Added to 1.5x branch in r7945

Added to trunk in r7946

comment:10 Changed 12 years ago by KyleK

  • Milestone changed from 1.51 to None Set
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version changed from 1.50 to 1.51

There's a bug in line 1201 of remote.c introduced with this patch:

total_up   += up;
total_down += up;

It should read:

total_up   += up;
total_down += down;

comment:11 Changed 12 years ago by charles

bah. :)

comment:12 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.52
  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in 1.5x: r7969

Fixed in trunk: r7970

comment:13 Changed 12 years ago by charles

  • Milestone changed from 1.52 to 1.51
  • Version changed from 1.51 to 1.50+
Note: See TracTickets for help on using tickets.