Opened 13 years ago

Closed 13 years ago

#1865 closed Bug (fixed)

Notifications should check notification server for capabilities before using actions

Reported by: bratsche Owned by: charles
Priority: Normal Milestone: 1.51
Component: GTK+ Client Version: 1.50
Severity: Normal Keywords:
Cc:

Description

Ubuntu Linux will be shipping a new notification server in the Jaunty release that is more geared towards usability. One of the things that is changed is that this server does not support actions in the notification bubbles.

Transmission should check that the server supports actions before calling notify_notification_add_action(), otherwise annoying popup dialogs appear.

Attachments (2)

notify-2.diff (1.9 KB) - added by bratsche 13 years ago.
Proposed patch
notify-3.diff (2.0 KB) - added by bratsche 13 years ago.
Free the list

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by bratsche

Proposed patch

Changed 13 years ago by bratsche

Free the list

comment:1 Changed 13 years ago by bratsche

Ignore the first patch.. I failed to free some memory in it. The newer patch (notify-3.diff) should be correct.

comment:2 Changed 13 years ago by livings124

  • Component changed from Transmission to GTK+ Client
  • Owner set to charles

comment:3 Changed 13 years ago by charles

  • Milestone changed from None Set to 1.51

comment:4 Changed 13 years ago by charles

  • Status changed from new to assigned

Thanks for the patch. Nice to get this in before 1.51, which is -probably- the version that will ship with 9.04

comment:5 Changed 13 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

added to trunk in r7943.

added to 1.5x branch in r7944.

Note: See TracTickets for help on using tickets.