Opened 14 years ago
Closed 14 years ago
#1882 closed Enhancement (fixed)
Add "watch directory" capabilities to transmission-daemon
| Reported by: | charles | Owned by: | charles |
|---|---|---|---|
| Priority: | Normal | Milestone: | 1.60 |
| Component: | Daemon | Version: | 1.51 |
| Severity: | Normal | Keywords: | |
| Cc: | 1100101@… |
Description
This is originally from ticket #1483, but because that ticket has two separate features -- watch-dir and move-when-torrent-finishes -- with different dependencies, I'm going to split the ticket.
Change History (7)
comment:1 Changed 14 years ago by charles
- Owner set to charles
- Status changed from new to assigned
comment:2 Changed 14 years ago by charles
- Component changed from Transmission to Daemon
- Resolution set to fixed
- Status changed from assigned to closed
comment:3 Changed 14 years ago by charles
- Resolution fixed deleted
- Status changed from closed to reopened
comment:4 Changed 14 years ago by charles
KyleK writes:
I saw that you removed the inotify() functionality in favor of an opendir() approach in one of the latest commits. May I suggest that this is only used as the last resort? (in case inotify is not available). My reasoning is two-fold: My NAS does support inotify(), and so do most current Linux distributions. It is a far more efficient way to react on folder/file changes than to do it in intervals. Also, the opendir() approach will basically prevent my NAS drives to go to standby. In case there are now active downloads, and I haven't placed any torrent files in the watchfolder, the drive still won't be able to spin down and conserve power, since it is accessed again and again. Let me know what you think.
comment:5 Changed 14 years ago by charles
bah, bitten by trac's WikiFormatting yet again. :)
KyleK writes:
I saw that you removed the inotify() functionality in favor of an opendir() approach in one of the latest commits. May I suggest that this is only used as the last resort? (in case inotify is not available).
My reasoning is two-fold: My NAS does support inotify(), and so do most current Linux distributions. It is a far more efficient way to react on folder/file changes than to do it in intervals.
Also, the opendir() approach will basically prevent my NAS drives to go to standby.
In case there are now active downloads, and I haven't placed any torrent files in the watchfolder, the drive still won't be able to spin down and conserve power, since it is accessed again and again.
Let me know what you think.
comment:6 Changed 14 years ago by KyleK
- Cc 1100101@… added
comment:7 Changed 14 years ago by charles
- Resolution set to fixed
- Status changed from reopened to closed
Added to trunk for 1.60 in r7974.
This doesn't use the inotify code submitted in #1483 and is potentially slower, but has the advantage that it'll be portable even to systems without inotify. Since we're only testing a single directory, nonrecursively, and at long intervals, hopefully this won't be too much of a problem.