Opened 12 years ago

Closed 12 years ago

#1997 closed Bug (fixed)

rpc-spec is missing some updates

Reported by: KyleK Owned by: charles
Priority: Normal Milestone:
Component: libtransmission Version: 1.52+
Severity: Normal Keywords:
Cc:

Description

doc/rpc-spec.txt lists the changes between versions of the RPC interface. The current table (at the end of the file) is missing some changes and also includes errors.

The attached patch adds some commands and fixes the errors. I can't guarantee that I missed some commands though :)

Attachments (2)

spec.patch (1.8 KB) - added by KyleK 12 years ago.
version-5.txt (3.6 KB) - added by charles 12 years ago.
KyleK: I noticed a couple of other errors in the diffs list and fixed those, and also sorted them by method to make it a little easier to read. Could you proof this to see if there are any other changes/errors that need to be made/fixed?

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by KyleK

comment:1 Changed 12 years ago by KyleK

Also, I think rpc-version-minimum needs to be bumped to '5' for the trunk (and later, 1.60), because many RPC commands were renamed and are thus incompatible with the older versions.

Changed 12 years ago by charles

KyleK: I noticed a couple of other errors in the diffs list and fixed those, and also sorted them by method to make it a little easier to read. Could you proof this to see if there are any other changes/errors that need to be made/fixed?

comment:2 Changed 12 years ago by charles

KyleK: I noticed a couple of other errors in the diffs list and fixed those, and also sorted them by method to make it a little easier to read. Could you proof this to see if there are any other changes/errors that need to be made/fixed?

comment:3 Changed 12 years ago by charles

  • Milestone None Set deleted
  • Status changed from new to assigned

comment:4 Changed 12 years ago by charles

KyleK has also correctly pointed out that ratio and uploadRatio are redundant, so maybe the new "ratio" field shouldn't be added to version 5 after all...

comment:5 Changed 12 years ago by charles

KyleK: revised version is now in r8259. If this version looks correct to you, please close this ticket when you get back from dinner :)

comment:6 Changed 12 years ago by KyleK

  • Resolution set to fixed
  • Status changed from assigned to closed

Yes, all looks well with the changes.

Note: See TracTickets for help on using tickets.