Opened 12 years ago

Closed 10 years ago

#2011 closed Enhancement (fixed)

when scrape return "failure reason" key, increase the interval between retries

Reported by: HSerg Owned by: charles
Priority: Normal Milestone: 2.30
Component: libtransmission Version: 1.52
Severity: Normal Keywords:
Cc:

Change History (5)

comment:1 Changed 12 years ago by charles

  • Milestone changed from None Set to Sometime
  • Status changed from new to assigned

Not sure why this ticket slipped through the cracks; it sounds like a good idea to me.

comment:2 Changed 11 years ago by jordan

  • Resolution set to invalid
  • Status changed from assigned to closed

Actually, in practice this doesn't seem to matter much. (1) Transmission already grows the retry interval when there's an error; (2) not many trackers seem to support "failure reason" for scrape, (3) having multiple trackers in a tier means we'll cycle to the next tracker anyway if there's an error.

comment:3 Changed 11 years ago by HSerg

(1) Wrong for "failure reason". (2) Often. (3) Wrong for "failure reason".

Example for Transmission 2.13 and http://code.google.com/p/torrentpier/

responseCode == 200

d14:failure reason22:Please disable SCRAPE!8:intervali1800ee
if( 200 <= responseCode && responseCode <= 299 )
{
    const int interval = tier->scrapeIntervalSec;
    tier->scrapeAt = now + interval;

    if( responseCode == HTTP_OK )
        success = parseScrapeResponse( tier, response, responseLen,
                                       tier->lastScrapeStr, sizeof( tier->lastScrapeStr ) );
    else
        tr_snprintf( tier->lastScrapeStr, sizeof( tier->lastScrapeStr ),
                     _( "tracker gave HTTP Response Code %1$ld (%2$s)" ),
                     responseCode, tr_webGetResponseStr( responseCode ) );
    tr_tordbg( tier->tor, "%s", tier->lastScrapeStr );
}

comment:4 Changed 11 years ago by HSerg

  • Resolution invalid deleted
  • Status changed from closed to reopened

comment:5 Changed 10 years ago by jordan

  • Milestone changed from Sometime to 2.30
  • Resolution set to fixed
  • Status changed from reopened to closed

This was fixed as part of the announcer refactoring in r12127 for ticket #117.

Note: See TracTickets for help on using tickets.