Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2039 closed Bug (invalid)

patch to build on Solaris with Sun compilers

Reported by: av Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version: 1.52
Severity: Minor Keywords:
Cc:

Description

Here are two trivial changes to be able to build Transmission on Solaris with Sun compilers. These changes are compatible with GCC.

diff -r transmission-1.52/third-party/libevent/test/regress.gen.h transmission-1.52a/third-party/libevent/test/regress.gen.h
13,14c13,14
< #define EVTAG_ASSIGN(msg, member, args...) (*(msg)->base->member##_assign)(msg, ## args)
< #define EVTAG_GET(msg, member, args...) (*(msg)->base->member##_get)(msg, ## args)
---
> #define EVTAG_ASSIGN(msg, member, ...) (*(msg)->base->member##_assign)(msg, ## __VA_ARGS__)
> #define EVTAG_GET(msg, member, ...) (*(msg)->base->member##_get)(msg, ## __VA_ARGS__)
diff -r transmission-1.52/third-party/libnatpmp/getgateway.c transmission-1.52a/third-party/libnatpmp/getgateway.c
46c46
< #if (defined(sun) && defined(__SVR4))
---
> #if (defined(__sun) && defined(__SVR4))

Configure command is:

./configure CC=c99 CXX=CC CFLAGS='-D__EXTENSIONS__ -mt'

Change History (3)

comment:1 Changed 12 years ago by charles

  • Resolution set to invalid
  • Status changed from new to closed

av:

I don't really have any control over the code you specified here...

(1) you need to submit the libevent changes upstream to the libevent developers.

(2) you need to submit the libnatpmp changes upstream to the libnatpmp developers.

(3) we don't have any control over what arguments users pass into configure. this could be added to the README, I suppose, but otherwise, what did you want us to do with this? :)

I do appreciate your work in tracking down this bug, which is pretty subtle IMO. However I don't see any action items for me in this ticket...

comment:2 Changed 12 years ago by av

OK, I'll contact developers of those libraries directly.

And I would be happy if you put instructions for building on Solaris with Sun compilers either in README or somewhere on your website. It could save somebody a couple of hours that I've already spent.

comment:3 Changed 12 years ago by charles

Sun C hints added in r8366

Note: See TracTickets for help on using tickets.