JSON_parse.c doesn't parse floating-point numbers correctly in some locales

[simonbcn]

When I see the torrent list in QTransmission (connected to transmission-daemon in remote machine) doesn't inform the percentage nor progress bar.
The percentage is 0 ever The percentage is always 0 and the progress bar is always empty, until the torrent is completed, then it shows 100% and progress bar full.

[charles]

are you connected to a 1.60 daemon?

[charles]

10:43 <@charles_> could another Qt client user take a look at #2046?
10:45 < kjg> !ticket 2046
10:45 <@Stickshift> kjg: http://www.transmissionbt.com/trac/ticket/2046
10:47 < kjg> works for me. Using certain qt styles, the inner progress bar disappears when the widget is disabled, but i don't think that's what he is talking about.

Also, as screenshot of it working when connected to a 1.60 daemon:

​http://www.transmissionbt.com/images/screenshots/transmission-1.60-qt-beta.png

[simonbcn]

$ transmission-daemon -V
Transmission 1.60 (8339)

I attach a screenshot

[charles]

Could you please attach a screenshot of the "Activity" tab from the properties dialogs of

• one of the torrents showing 100% and

• one of the torrents showing 0% that isn't really at 0%

Thanks...

[simonbcn]

Screenshot incomplete torrent

[simonbcn]

Screenshot complete torrent

[simonbcn]

I have uploaded one screenshot of updated torrent list
The torrent strikethrough with red bar corresponds to incomplete torrent:
The torrent strikethrough with blue bar corresponds to complete torrent:

If you need something more, here I am.
Greetings.

[simonbcn]

Other bug:
It does not update the ratio either.
The torrent strikethrough with blue bar, it has uploaded 1'9GB but its ratio is 0.00.

[charles]

Thanks for the fast update.

The progressbar's percentage should be coming directly from the "percentDone" field from the server.

Let's try this. Could you apply the following test patch, which will dump out to the terminal some of the raw field values that are being used to set the main window's gui.

If you could attach a few hundred lines of that output to this ticket, that might be helpful.

The dump will give the torrent name, percentDone, sizeWhenDone, and leftUntilDone fields. The name field is only there to make it easier for you to match the text up with the gui, but I don't need/want to know the names of the torrents.

Thanks!

[simonbcn]

Output QTransmission

[charles]

Interesting. In *every case* the percentDone is either 1 or 0. I wonder why?

[charles]

simonbcn: what environment settings are you using for your locale? I'm wondering if there's an error parsing the floating-point number.

Are you in a locale that uses a period for a decimal point, or something else such as a comma?

[charles]

If it's a locale problem, I think I've found the bug in the third-party JSON parser we use. Could you please apply the following patch and see if it fixes things?

[charles]

possible fix to a locale bug when parsing floating-point numbers in the JSON parser

[simonbcn]

Thank you. Bug solved.

[charles]

Committed in r8372 for 1.61.

I also reported the bug upstream to JSON_parser.c's author, Jean Gressmann