Opened 12 years ago

Closed 12 years ago

#2099 closed Bug (invalid)

Build fails because of tr_dhtInit

Reported by: kab Owned by: charles
Priority: Normal Milestone: None Set
Component: libtransmission Version: 1.60+
Severity: Normal Keywords:
Cc:

Description

Hi, since svn 8440 the svn build fails on ubuntu jaunty because of the tr-dht code. The last revision tested is 8450.

-MF .deps/tr-dht.Tpo -c -o tr-dht.o tr-dht.c
tr-dht.c: In function 'tr_dhtInit':
tr-dht.c:155: error: expected expression before '>>' token
tr-dht.c:156: error: lvalue required as unary '&' operand
make[3]: *** [tr-dht.o] Error 1
make[3]: *** Waiting for unfinished jobs....
mv -f .deps/tracker.Tpo .deps/tracker.Po
make[3]: Leaving directory `/build/buildd/transmission-1.70/libtransmission'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/build/buildd/transmission-1.70/libtransmission'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/build/buildd/transmission-1.70'
make: *** [build-stamp] Error 2
dpkg-buildpackage: failure: debian/rules build gave error exit status 2
******************************************************************************
Build finished at 20090520-0706
FAILED [dpkg-buildpackage died]

Change History (9)

comment:1 Changed 12 years ago by charles

do you not have SVN_REVISION_NUM #defined in libtransmission/version.h?

comment:2 Changed 12 years ago by charles

kab: it's building fine for me here, and in the automated linux tarball build... could you confirm whether or not the build is still broken for you?

comment:3 Changed 12 years ago by kab

After svn checkout, autogen.sh does not create libtransmission/version.h on my machine. What commands have you used to build?

comment:4 Changed 12 years ago by charles

it's generated when you run `make' for the first time in the libtransmission directory.

See this build log for example...

Making check in libtransmission
make[1]: Entering directory `/home/transmission/hudson/workspace/trunk-linux-inc/trunk/libtransmission'
echo '#define PEERID_PREFIX         "'-TR161Z-'"' > version.h
echo '#define USERAGENT_PREFIX      "'1.61+'"' >> version.h
echo '#define SVN_REVISION          "'`svn info | grep "Revision" | awk -F': ' '{print $2}'`'"' >> version.h
echo '#define SVN_REVISION_NUM      '`svn info | grep "Revision" | awk -F': ' '{print $2}'`'' >> version.h
echo '#define SHORT_VERSION_STRING  "'1.61+'"' >> version.h
echo '#define LONG_VERSION_STRING   "'1.61+' ('`svn info | grep "Revision" | awk -F': ' '{print $2}'`')"' >> version.h
make  check-am

comment:5 Changed 12 years ago by kab

So that seems to be the problem. My build script make's an svn export before running ./autogen.sh and later make. The .svn directory is not included in the directory for the upload to the build machine. Is there an easy way to generate a working version.h file after an svn export?

comment:6 Changed 12 years ago by charles

Is there an easy way to generate a working version.h file after an svn export?

not without running "make version.h" in the libtransmission directory.

I'm not sure why this has just now started failing, though. utils.c, web.c, session.c, rpcimpl.c, and makemeta.c are all in libtransmission, and all of them require some of the #defines from version.h... so in order for your script to have been working up until now, you must've had version.h present...

comment:7 Changed 12 years ago by kab

  • Resolution set to fixed
  • Status changed from new to closed

Ok. Thanks for the answers. I will alter my build script, so it generates the version.h file first before packing.

But it's very interesting. The old build script had never a mechanism to generate the version.h file.

Thanks for the help.

comment:8 Changed 12 years ago by charles

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:9 Changed 12 years ago by charles

  • Resolution set to invalid
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.