Opened 14 years ago

Closed 14 years ago

#2138 closed Bug (duplicate)

./ generates unsuported version.h

Reported by: kab Owned by: charles
Priority: Low Milestone: None Set
Component: libtransmission Version: 1.61+
Severity: Normal Keywords: needinfo
Cc: wermut@…


Since ./ can generate the version.h file now, I have tested the functionality a little bit. After an svn export, generates a version.h file with the following content:

#define PEERID_PREFIX         "-TR161Z-'"
#define USERAGENT_PREFIX      "1.61+'"
#define SVN_REVISION          "exported"
#define SVN_REVISION_NUM      exported
#define SHORT_VERSION_STRING  "1.61+"
#define LONG_VERSION_STRING   "1.61+ (exported)"

The make will abort with:

rite-strings -Wextra -Wdeclaration-after-statement -Winit-self -MT tr-dht.o -MD -MP -MF .deps/tr-dht.Tpo -c -o tr-dht.o tr-dht.c
tr-dht.c: In function ‘tr_dhtInit’:
tr-dht.c:156: error: ‘exported’ undeclared (first use in this function)
tr-dht.c:156: error: (Each undeclared identifier is reported only once
tr-dht.c:156: error: for each function it appears in.)
make[1]: *** [tr-dht.o] Error 1
make[1]: Leaving directory `/media/hd2/debian/transmission-nightly/nightly-intrepid/libtransmission'
make: *** [all-recursive] Error 1

telling that "exported" is not declared. My new auto build script goes arround the problem, but it would be nice if someone could fix that.

Change History (4)

comment:1 Changed 14 years ago by charles

  • Keywords needinfo added

kab: I completely agree with what you're saying, but how would you suggest I "fix that" s.t. we get the svn revision info in an svn export'ed directory?

comment:2 Changed 14 years ago by kab

I think should abort and complain about the missing .svn folder inside libtransmission and don't generate the version.h.

The second possibility is to adjust the code to support the version "exported" or create an other working dummy.

comment:3 Changed 14 years ago by charles

kab: does r8572 work any better?

comment:4 Changed 14 years ago by charles

  • Resolution set to duplicate
  • Status changed from new to closed

Actually it looks like this ticket is a continuance of #2125. Please let's continue this thread in that ticket.

Note: See TracTickets for help on using tickets.