Opened 11 years ago

Closed 11 years ago

#2157 closed Enhancement (fixed)

Web UI should support "turtle mode"

Reported by: charles Owned by: kjg
Priority: Normal Milestone: 1.80
Component: Web Client Version: 1.61
Severity: Normal Keywords:
Cc: ian@…

Description

Summary says it all.

This is about the same priority as the other tickets for getting the web client up to par with the other gui clients. It's not urgent, but needs to happen sooner or later.

Attachments (2)

turtle.diff (18.6 KB) - added by Grug 11 years ago.
Add turtle options to the web client (tidy'd up the tabs with more CSS)
turtle.2.diff (2.5 KB) - added by Grug 11 years ago.
Add refresh of session - diff'd against current SVN (diff above already committed)

Download all attachments as: .zip

Change History (15)

comment:1 Changed 11 years ago by kjg

  • Milestone changed from None Set to 1.80
  • Status changed from new to assigned

comment:2 Changed 11 years ago by livings124

#1494 touches upon this as well.

comment:3 Changed 11 years ago by medicineuk

  • Resolution set to duplicate
  • Status changed from assigned to closed

comment:4 Changed 11 years ago by kjg

  • Resolution duplicate deleted
  • Status changed from closed to reopened

comment:5 Changed 11 years ago by kjg

  • Milestone 1.80 deleted

comment:6 Changed 11 years ago by charles

  • Milestone set to None Set

Changed 11 years ago by Grug

Add turtle options to the web client (tidy'd up the tabs with more CSS)

comment:7 Changed 11 years ago by Grug

  • Cc ian@… added

This patch adds tabs to the preferences dialog to list the speed related options (as per 1.76 GTK client). There is some CSS work to "pretty" up the tabs, but more could be done if someone was keen. Making things pretty isn't really my forte.

The turtle days selector is currently a drop-down listbox as per the 1.76 GTK client. This could be changed to a series of checkboxes if desired.

comment:8 Changed 11 years ago by kjg

  • Milestone changed from None Set to 1.80
  • Resolution set to fixed
  • Status changed from reopened to closed

patch applied in r9507. Thanks a ton!

comment:9 Changed 11 years ago by Waldorf

  • Resolution fixed deleted
  • Status changed from closed to reopened

In my testing, the Web UI doesn't seem to check for change of "Turtle Mode". ie. if I change to/from turtle mode, the web ui won't display the change.

comment:10 follow-up: Changed 11 years ago by Grug

Oh damn! I was going to ask kjg how we should handle that last night but forgot.

I'm not sure how best to get around it. All I can think of is to query the turtle status as part of the client refresh... the problem with this being that the "session-get" RPC call doesn't take any arguments, which means you get *every* variable *every* refresh. Not really practical.

In short, the only "proper" way I can think of is to adjust the RPC to either allow args to "session-get" (no args = all as usual), or another RPC command (overkill).

I'm happy to write a patch for the RPC if desired.

comment:11 in reply to: ↑ 10 Changed 11 years ago by charles

Replying to Grug:

Oh damn! I was going to ask kjg how we should handle that last night but forgot.

I'm not sure how best to get around it. All I can think of is to query the turtle status as part of the client refresh... the problem with this being that the "session-get" RPC call doesn't take any arguments, which means you get *every* variable *every* refresh. Not really practical.

In short, the only "proper" way I can think of is to adjust the RPC to either allow args to "session-get" (no args = all as usual), or another RPC command (overkill).

I'm hesitant to change the RPC for 1.80 at this late date. IMO the thing to do for 1.80 would be to keep the existing session-get semantics, but poll infrequently, say, every 5 or 10 seconds.

Changed 11 years ago by Grug

Add refresh of session - diff'd against current SVN (diff above already committed)

comment:12 Changed 11 years ago by Grug

The remaining concerns for this one are session variables being changed in another client whilst the preferences window is open.

Refreshing the session data replaces the contents of controls directly, so when an update happens, it would nuke any settings you are changing locally. For this reason I have disabled the timer whilst the preferences window is open.

A secondary problem is that the preferences window commits the values for _every_ field, not just those changed. Therefore if something gets changed on another client whilst this prefs window is open the change will be overwritten.

Given the longevity of this client I think the current patch is sufficient as it gets things working for most people. To some extent, anyone silly enough to be changing prefs in multiple clients simultaneously is just asking for trouble anyway, although external scripts changing prefs (eg cronjob) are valid possibility.

comment:13 Changed 11 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

turtle.2.diff applied to trunk for 1.80 by r9523

Note: See TracTickets for help on using tickets.