Opened 13 years ago

Closed 13 years ago

#2199 closed Bug (fixed)

DHT should not announce stopped torrents

Reported by: jch Owned by: charles
Priority: High Milestone: 1.72
Component: libtransmission Version: 1.71
Severity: Normal Keywords: dht
Cc:

Description

We're announcing stopped torrents to the DHT, which is stupid for at least two reasons:

  • it creates extra DHT traffic for people with a lot of stopped torrents;
  • we'll be contacted by random peers that we induced to believe that we're participating in our stopped torrents.

The attached patch fixes that.

By the way, it looks like there's some code duplication: starting torrents is done in both checkAndStartImpl and torrentStart. Since I don't understand the distinction between the two, the attached patch changes to trigger a DHT announce from both (it used to be done in the former only).

--Juliusz

Attachments (1)

transmission-dht-stopped.patch​ (940 bytes) - added by jch 13 years ago.

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by jch

comment:1 Changed 13 years ago by charles

  • Milestone changed from None Set to 1.72
  • Status changed from new to assigned

comment:2 Changed 13 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

added to trunk in r8672 for 1.72.

Note: See TracTickets for help on using tickets.