Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#2225 closed Enhancement (fixed)

support supportcrypto and requirecrypto flags in http tracker announces

Reported by: lurktomten Owned by: charles
Priority: Lowest Milestone: 1.73
Component: Transmission Version: 1.72
Severity: Normal Keywords:
Cc:

Description

When encrytion is turned on, "prefer encrypted peers", it's not showed in tracker stats. The encryption flag is not properly set.

Change History (13)

comment:1 Changed 13 years ago by charles

I don't know what "not showed in tracker stats" means. Could you please explain this more?

comment:2 Changed 13 years ago by lurktomten

Some trackers keep track of what clients are encrypted and the ones that's not. The RC (requires encryption) and SC (supports encryption) flags are part of the official bittorent protocol.

If the flags are not properly set, other clients with active RC flag like Vuze/Azureus? will not establish a connection at all with the Transmission client. This, ofcource, affects the number of peers Transmission connects to.

In short: Clients with RC flag set does not connect to clients that don't set SC and RC flag.

comment:3 Changed 13 years ago by lurktomten

  • Severity changed from Normal to Critical

comment:4 Changed 13 years ago by charles

  • Milestone changed from 1.80 to Sometime
  • Owner set to charles
  • Priority changed from Highest to Lowest
  • Severity changed from Critical to Normal
  • Status changed from new to assigned

I can't find references to SC and RC anywhere, much less in the official bittorrent spec. I'm going to assume you're referring to the Azureus extension flags "supportcypto" and "requirecrypto". It's not clear how many trackers actually support this.

These flags are not supported at all by KTorrent, or rTorrent, or in the latest libtorrent stable release, which means its frontends (Deluge, Halite, and a dozen others) also don't support this.

It probably couldn't hurt to add these flags into libtransmission, but your "in short" summary is flat-out wrong and in no way is this critical or a high priority.

Lastly, do not set milestones unless you're attaching a patch to the ticket and you've gotten the goahead from a dev. Otherwise, you're implicitly giving us marching orders.

comment:5 Changed 13 years ago by charles

  • Type changed from Bug to Enhancement

comment:6 Changed 13 years ago by charles

followup: uTorrent doesn't support this yet, either. http://forum.utorrent.com/viewtopic.php?id=53653

So this is nice-to-have, but not urgent, not critical.

comment:7 Changed 13 years ago by charles

  • Milestone changed from Sometime to 1.73

the good news is that it only takes three lines to add this...

comment:8 Changed 13 years ago by charles

  • Summary changed from Encryption flag not set to support supportcypto and requirecrypto flags in http tracker announces

comment:9 Changed 13 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

added in r8718

comment:10 Changed 13 years ago by livings124

  • Summary changed from support supportcypto and requirecrypto flags in http tracker announces to support supportcrypto and requirecrypto flags in http tracker announces

comment:11 Changed 13 years ago by lurktomten

Thanks for this!

comment:12 Changed 13 years ago by charles

  • Keywords backport-1.5x added

comment:13 Changed 13 years ago by charles

  • Keywords backport-1.5x removed
Note: See TracTickets for help on using tickets.