Opened 13 years ago

Closed 12 years ago

#2294 closed Enhancement (fixed)

Add "Select/Deselect All" buttons to file selector

Reported by: nnc Owned by: kjg
Priority: Normal Milestone: 1.80
Component: Web Client Version: 1.73
Severity: Normal Keywords:
Cc: ian@…

Description

This would come in very handy when you have a torrent with hundreds of files, and you only want a couple. It would be a lot easier to deselect them all, and then only select a few that you actually want. Right now, its really painful deselecting hundreds of files by hand.

Attachments (2)

select.diff (7.7 KB) - added by Grug 13 years ago.
Add (De)Select All buttons to the Inspector (rename references to the correct term "Deselect"
select.2.diff (8.1 KB) - added by Grug 13 years ago.
Add (De)Select All buttons to the Inspector ((de)select only files able to be changed - unfinished and !single)

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by charles

  • Summary changed from Add "Select/Deselect All" buttons to Web UI file selector to Add "Select/Deselect All" buttons to file selector

comment:2 Changed 13 years ago by Grug

  • Cc ian@… added

This patch adds the buttons to the file selector part of the inspector. The buttons are hidden when there are no torrents selected, and are show if any or multiple torrents are selected.

There is no parsing to enable or disable either button as it requires large amounts of delving into the non-exported portions of the torrent files code, and seems to be refreshed every couple of seconds?.

Either action is allowed on all files at any time. I noticed that the web client differs from the gtk client in that it disables deselecting files that are single.

Changed 13 years ago by Grug

Add (De)Select All buttons to the Inspector (rename references to the correct term "Deselect"

comment:3 Changed 13 years ago by kjg

It looks pretty good. The only issue it changes the wanted status on already completed files too.

Changed 13 years ago by Grug

Add (De)Select All buttons to the Inspector ((de)select only files able to be changed - unfinished and !single)

comment:4 Changed 13 years ago by Grug

The original diff follows the behaviour of the gtk client, which is to (de)select any file irrespective of its status. The code for this is much more straightforward, simply sending a call to the RPC with the list of torrents for each button.

The second diff follows the behaviour of the Mac client, which is to (de)select only files that are changable (ie: are unfinished and are not the only file in the torrent). Because of this behaviour the code is more complex making individual calls to the RPC for each torrent, due to the need to list exactly which files are changing state.

comment:5 follow-up: Changed 13 years ago by nnc

I originally asked for this feature to be added intending to always use it on a single torrent. So the described way that Mac client does it makes most sense to me. Although I didn't yet try either patch, I don't see how this could come in useful when you have multiple torrents selected as you can't see files from multiple torrents in the file selector at the same time, right?

comment:6 in reply to: ↑ 5 Changed 13 years ago by Grug

Replying to nnc:

I don't see how this could come in useful when you have multiple torrents selected as you can't see files from multiple torrents in the file selector at the same time, right?

Wrong. If you select multiple files it displays the file lists one after another in the Inspector.

comment:7 Changed 13 years ago by nnc

Sorry, didn't know that. But still, second patch makes more sense to me, despite some additional overhead, as this feature will probably most often be used on one torrent at a time, so sacrificing correctness of second patch for efficiency of the first one is not worth it IMO.

comment:8 Changed 12 years ago by kjg

  • Milestone changed from None Set to 1.80
  • Resolution set to fixed
  • Status changed from new to closed

applied in r9677

Note: See TracTickets for help on using tickets.