Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2296 closed Bug (invalid)

updateminiupnpcstrings.sh fails if OS version contains /

Reported by: geirha Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version: 1.73
Severity: Normal Keywords:
Cc:

Description

The script uses sed substitution to replace the dummy version in the template header, and since the substitution uses / as delimiter, it naturally breaks when the version string contains a /.

A quick fix is to use a different delimiter, like |. Of course, that will fail if some OS happens to have a | in the version string, but I don't think there's any safe character to use (is there a naming policy somewhere?). It would probably be better to do it similar to the update-version-h.sh script.

I'm attaching the quickfix mentioned above, and I also took the liberty of removing the useless use of cat.

Attachments (1)

updateminiupnpcstrings.sh.patch (781 bytes) - added by geirha 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by geirha

comment:1 Changed 12 years ago by livings124

Thanks for the report! We don't maintain miniupnp - can you report this upstream to the miniupnp developer?

comment:2 Changed 12 years ago by livings124

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.