Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2318 closed Bug (fixed)

pex and .resume get a list of connected peers, not known peers

Reported by: charles Owned by: charles
Priority: Normal Milestone: 1.74
Component: libtransmission Version: 1.73
Severity: Normal Keywords:
Cc:

Description

This appears to be due to a bug in tr_peerMgrGetPeers(), but it results in suboptimal resumption when starting a new session, and suboptimal peer sharing in settings where PEX is allowed.

The fix is very simple: instead of iterating through the tr_peer array (which is a list of peers we're connected to), tr_peerMgrGetPeers() should iterate through the struct peer_atom array (which is a list of all the peers we're aware of).

Change History (4)

comment:1 Changed 12 years ago by charles

  • Owner set to charles
  • Status changed from new to assigned

fix implemented in trunk by r8879 for 1.74 or 1.80, whichever comes first.

comment:2 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:3 Changed 12 years ago by charles

  • Summary changed from pex and .resume get a list of peers we're connected to. they should get a list of all known peers to pex and .resume get a list of connected peers, not known peers

comment:4 Changed 12 years ago by charles

  • Component changed from Transmission to libtransmission
Note: See TracTickets for help on using tickets.