Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2330 closed Bug (fixed)

on some versions of GTK+, error messages can't be seen in the main window

Reported by: charles Owned by: charles
Priority: Normal Milestone: 1.74
Component: GTK+ Client Version: 1.73
Severity: Normal Keywords:
Cc:

Description

I can't reproduce this on my Fedora 11 box, so I think it has to do with machines running older versions of GTK+.

Torrent-cell-renderer.c has two different text renderers: one that uses the default text renderer settings to render non-error torrents, and one with a red foreground to render error torrents.

When using the error text renderer, whose "foreground" property is set to red, and its "sensitive" property is set to false (when the torrent is stopped), then the renderer breaks and uses a white foreground instead. The list's background color, on most common GTK+ themes, is also white, so the torrent's rendered text becomes invisible -- exactly the opposite of the effect we'd wanted for error torrents.

I don't see any property for setting the non-sensitive foreground color.

The simplest fix for this is probably to leave the "sensitive" property set to true when using the error text renderer.

Change History (4)

comment:1 Changed 12 years ago by charles

  • Status changed from new to assigned

comment:2 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in trunk by r8909 for 1.74

comment:3 Changed 12 years ago by charles

  • Summary changed from torrents with errors should be shown in red, but instead become invisible to on some versions of GTK+, error messages are hard to read in the main window's torrent list

comment:4 Changed 12 years ago by charles

  • Summary changed from on some versions of GTK+, error messages are hard to read in the main window's torrent list to on some versions of GTK+, error messages can't be seen in the main window
Note: See TracTickets for help on using tickets.